From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43250) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XP9lP-0005sp-Ep for qemu-devel@nongnu.org; Wed, 03 Sep 2014 08:34:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XP9lK-0006ZF-8P for qemu-devel@nongnu.org; Wed, 03 Sep 2014 08:34:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:23190) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XP9lJ-0006Z2-VX for qemu-devel@nongnu.org; Wed, 03 Sep 2014 08:34:10 -0400 Message-ID: <54070ABD.2080207@redhat.com> Date: Wed, 03 Sep 2014 06:34:05 -0600 From: Eric Blake MIME-Version: 1.0 References: <1409205191-11406-1-git-send-email-famz@redhat.com> <53FFABDB.2000609@redhat.com> <20140829005500.GD4196@T430.redhat.com> <20140903111046.GH7717@noname.str.redhat.com> In-Reply-To: <20140903111046.GH7717@noname.str.redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="1xDpKIgTrnEOeeafG0DFsUtlFqipfXkpK" Subject: Re: [Qemu-devel] [PATCH v3] block: Introduce "null" driver List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , Fam Zheng Cc: benoit.canet@irqsave.net, qemu-devel@nongnu.org, Stefan Hajnoczi , armbru@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --1xDpKIgTrnEOeeafG0DFsUtlFqipfXkpK Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 09/03/2014 05:10 AM, Kevin Wolf wrote: >>>> @@ -1150,7 +1150,8 @@ >>>> 'data': [ 'archipelago', 'file', 'host_device', 'host_cdrom', 'ho= st_floppy', >>>> 'http', 'https', 'ftp', 'ftps', 'tftp', 'vvfat', 'blkde= bug', >>>> 'blkverify', 'bochs', 'cloop', 'cow', 'dmg', 'parallels= ', 'qcow', >>>> - 'qcow2', 'qed', 'raw', 'vdi', 'vhdx', 'vmdk', 'vpc', 'q= uorum' ] } >>>> + 'qcow2', 'qed', 'raw', 'vdi', 'vhdx', 'vmdk', 'vpc', 'q= uorum', >>>> + 'null' ] } >>> >>> As mentioned elsewhere, you probably want 'null' AND 'null-co'. Bumm= er >>> that this list is mostly alphabetical, but that 'quorum' and 'null' a= re >>> out of order. >> >> I'll add null-co to the list. But this list is a bit far from alphabet= ical: >> >> archipelago, ..., vvfat, blkdebug,... >=20 > Actually it's pretty close to alphabetical as the secondary criterion > (the primary one is that all protocols are listed first, and only then > the formats). Then a (separate) patch that lists: 'data': [ # protocols list..., # formats list... ] might be nice :) --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --1xDpKIgTrnEOeeafG0DFsUtlFqipfXkpK Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUBwq9AAoJEKeha0olJ0NqpmAH/izLAUGuqCx0hpOsBHvIQ0kV wezmw4JebifTi+y9KyZmr/+p7b+/qXAbMyOcPqevIeXASPnpG/dqexEacslzrHmG qdnknZegx1epeaGS/RoCotZ6uM/v54+j8n3Hz7WMbJoVRJ+VHmJb7Qn7rprCFNWW cDxhpXi7VDPrIgWa2PZED7frtE0s3NvoMs79l/wBq40kRbWKGaTJaAHru0mpgA1n fxafrGtUMU5rKFg/wv1T47244uAW/HjhsdU1RGe28v+g3ifW85PXbRiRCFiFy9BM 889CvHQrUzmNLOC/v2e1sU96nCQDswCnt3xfSmR16K37IvygQqXRGBDmJvyDWsM= =nqz6 -----END PGP SIGNATURE----- --1xDpKIgTrnEOeeafG0DFsUtlFqipfXkpK--