From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34848) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XPCol-0000QT-Ng for qemu-devel@nongnu.org; Wed, 03 Sep 2014 11:50:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XPCog-0005ub-Pa for qemu-devel@nongnu.org; Wed, 03 Sep 2014 11:49:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46964) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XPCog-0005sz-Hk for qemu-devel@nongnu.org; Wed, 03 Sep 2014 11:49:50 -0400 Message-ID: <54072A06.50101@redhat.com> Date: Wed, 03 Sep 2014 08:47:34 -0600 From: Eric Blake MIME-Version: 1.0 References: <1409671532-12706-1-git-send-email-david.marchand@6wind.com> <5406290C.3010105@redhat.com> <54071135.30100@6wind.com> In-Reply-To: <54071135.30100@6wind.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="6L4KO5xOUKfbkQQPThBhBUWKWFqweO91D" Subject: Re: [Qemu-devel] [PATCH v4 00/14] ivshmem: update documentation, add client/server tools List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Marchand Cc: kvm@vger.kernel.org, stefanha@gmail.com, claudio.fontana@huawei.com, qemu-devel@nongnu.org, armbru@redhat.com, arei.gonglei@huawei.com, pbonzini@redhat.com, jani.kokkonen@huawei.com, cam@cs.ualberta.ca This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --6L4KO5xOUKfbkQQPThBhBUWKWFqweO91D Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 09/03/2014 07:01 AM, David Marchand wrote: >> Rather than introducing new files with bugs, followed by patches to >> clean it up, why not just introduce the new files correct in the first= >> place? I think you are better off squashing in a lot of the cleanup >> patches into patch 1. >=20 > Actually, I mentioned this in a previous email but did not get any comm= ent. > So, I preferred to send the splitted patches to ease review (from my > point of view). It does not ease reviewer time to have a known buggy patch with later cleanups. I'd rather see your best effort at a bug-free patch to begin with, than to spend my time pointing out bugs only to find out you already fixed them later in the series. >=20 > Once code looks fine enough, I intend to keep only three patches : > - one for the initial import of ivshmem-client / server > - one for the documentation update > - one last with the protocol change If that is your plan for the final series, then that is the same plan you should be using for reviews. You want the reviewers to see your proposed final product, not your intermediate state of how you got there.= --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --6L4KO5xOUKfbkQQPThBhBUWKWFqweO91D Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUByoGAAoJEKeha0olJ0NqYLsH/inE6p7fNNxp048zPYMv+eAI aUu+eUklGejteKajUg+lS+yHDU+ghTkx/bpv732qN43Yc9u/b7kJ5I6xkbSm5Bv1 +WlZhBRJcUsGkPIbF+C5H//HLLPj/OVTF5Czh3f9hgMQSzIgJimL+jhbEVgGBIss wQ1Z1H+s3a7kaTBI1f2Zg1fv4elAcWcgX0lRfYHI82PVuxuQV875NwezbP0WTY7d gqfpae6kVe+bqv15TaNTsUUAoIyIH7YLBBAtr91qN/hA0epJsvtdiNACW1KGJ5c+ Jd+slquBx4pexR0SuCNRTGImT+WNqZYQuW/nicFnTmaSoAd+SYryn/Zp88gYu8Q= =vGPv -----END PGP SIGNATURE----- --6L4KO5xOUKfbkQQPThBhBUWKWFqweO91D--