From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51415)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1XPCC4-0005mr-PZ
	for qemu-devel@nongnu.org; Wed, 03 Sep 2014 11:10:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1XPCBy-0001qY-TK
	for qemu-devel@nongnu.org; Wed, 03 Sep 2014 11:09:56 -0400
Received: from mail-qa0-x22a.google.com ([2607:f8b0:400d:c00::22a]:46192)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1XPCBy-0001oB-NJ
	for qemu-devel@nongnu.org; Wed, 03 Sep 2014 11:09:50 -0400
Received: by mail-qa0-f42.google.com with SMTP id dc16so4031115qab.1
	for <qemu-devel@nongnu.org>; Wed, 03 Sep 2014 08:09:48 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <54072F34.2030808@twiddle.net>
Date: Wed, 03 Sep 2014 08:09:40 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1409658764-28113-1-git-send-email-peter.maydell@linaro.org>
	<1409658764-28113-3-git-send-email-peter.maydell@linaro.org>
	<CACXAS8AOjWvYYBVysw2-WhnfjQmoadZBVzc3fn2DZkHUkHG98w@mail.gmail.com>
In-Reply-To: <CACXAS8AOjWvYYBVysw2-WhnfjQmoadZBVzc3fn2DZkHUkHG98w@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 2/3] target-sparc: address_mask(),
 asi_address_mask() are TARGET_SPARC64 only
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Artyom Tarasenko <atar4qemu@gmail.com>, Peter Maydell <peter.maydell@linaro.org>
Cc: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>, qemu-devel <qemu-devel@nongnu.org>, patches@linaro.org

On 09/03/2014 01:49 AM, Artyom Tarasenko wrote:
> On Tue, Sep 2, 2014 at 1:52 PM, Peter Maydell <peter.maydell@linaro.org> wrote:
>> The address_mask() and asi_address_mask() functions are only used in
>> TARGET_SPARC64 configs, so guard with ifdefs to avoid warnings about
>> unused functions in 32-bit builds.
>>
>> Since the main reason these functions were marked 'inline' was to
>> suppress unused-function warnings with gcc, we remove the 'inline'
>> as no longer necessary.
> 
> I thought address_mask was inline because it's in the hot path.
> Wouldn't the removal hit performance?

The compiler will probably inline it itself as it sees fit.


r~