From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42963)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tommusta@gmail.com>) id 1XPFBV-0001zA-J2
	for qemu-devel@nongnu.org; Wed, 03 Sep 2014 14:21:42 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <tommusta@gmail.com>) id 1XPFBK-0005E4-3A
	for qemu-devel@nongnu.org; Wed, 03 Sep 2014 14:21:33 -0400
Message-ID: <54075C1A.7060605@gmail.com>
Date: Wed, 03 Sep 2014 13:21:14 -0500
From: Tom Musta <tommusta@gmail.com>
MIME-Version: 1.0
References: <1409246113-6519-1-git-send-email-pbonzini@redhat.com>
	<1409246113-6519-4-git-send-email-pbonzini@redhat.com>
In-Reply-To: <1409246113-6519-4-git-send-email-pbonzini@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 03/17] ppc: fix monitor access to CR
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: dgibson@redhat.com, qemu-ppc@nongnu.org

On 8/28/2014 12:14 PM, Paolo Bonzini wrote:
> This was off-by-one.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  monitor.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/monitor.c b/monitor.c
> index 34cee74..ec73dd4 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -2968,7 +2968,7 @@ static target_long monitor_get_ccr (const struct MonitorDef *md, int val)
>  
>      u = 0;
>      for (i = 0; i < 8; i++)
> -        u |= env->crf[i] << (32 - (4 * i));
> +        u |= env->crf[i] << (32 - (4 * (i + 1)));
>  
>      return u;
>  }
> 

Reviewed-by: Tom Musta <tommusta@gmail.com>