From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44343)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tommusta@gmail.com>) id 1XPFID-0005i3-ND
	for qemu-devel@nongnu.org; Wed, 03 Sep 2014 14:28:38 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <tommusta@gmail.com>) id 1XPFI4-0007PV-Ik
	for qemu-devel@nongnu.org; Wed, 03 Sep 2014 14:28:29 -0400
Message-ID: <54075DBD.9000800@gmail.com>
Date: Wed, 03 Sep 2014 13:28:13 -0500
From: Tom Musta <tommusta@gmail.com>
MIME-Version: 1.0
References: <1409246113-6519-1-git-send-email-pbonzini@redhat.com>
	<1409246113-6519-7-git-send-email-pbonzini@redhat.com>
In-Reply-To: <1409246113-6519-7-git-send-email-pbonzini@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 06/17] ppc: use CRF_* in int_helper.c
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: dgibson@redhat.com, qemu-ppc@nongnu.org

On 8/28/2014 12:15 PM, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  target-ppc/int_helper.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/target-ppc/int_helper.c b/target-ppc/int_helper.c
> index f6e8846..9c1c5cd 100644
> --- a/target-ppc/int_helper.c
> +++ b/target-ppc/int_helper.c
> @@ -2303,25 +2303,25 @@ uint32_t helper_bcdadd(ppc_avr_t *r,  ppc_avr_t *a, ppc_avr_t *b, uint32_t ps)
>          if (sgna == sgnb) {
>              result.u8[BCD_DIG_BYTE(0)] = bcd_preferred_sgn(sgna, ps);
>              zero = bcd_add_mag(&result, a, b, &invalid, &overflow);
> -            cr = (sgna > 0) ? 4 : 8;
> +            cr = (sgna > 0) ? 1 << CRF_GT : 1 << CRF_LT;
>          } else if (bcd_cmp_mag(a, b) > 0) {
>              result.u8[BCD_DIG_BYTE(0)] = bcd_preferred_sgn(sgna, ps);
>              zero = bcd_sub_mag(&result, a, b, &invalid, &overflow);
> -            cr = (sgna > 0) ? 4 : 8;
> +            cr = (sgna > 0) ? 1 << CRF_GT : 1 << CRF_LT;
>          } else {
>              result.u8[BCD_DIG_BYTE(0)] = bcd_preferred_sgn(sgnb, ps);
>              zero = bcd_sub_mag(&result, b, a, &invalid, &overflow);
> -            cr = (sgnb > 0) ? 4 : 8;
> +            cr = (sgnb > 0) ? 1 << CRF_GT : 1 << CRF_LT;
>          }
>      }
>  
>      if (unlikely(invalid)) {
>          result.u64[HI_IDX] = result.u64[LO_IDX] = -1;
> -        cr = 1;
> +        cr = 1 << CRF_SO;
>      } else if (overflow) {
> -        cr |= 1;
> +        cr |= 1 << CRF_SO;
>      } else if (zero) {
> -        cr = 2;
> +        cr = 1 << CRF_EQ;
>      }
>  
>      *r = result;
> 

Reviewed-by: Tom Musta <tommusta@gmail.com>
Tested-by: Tom Musta <tommusta@gmail.com>