From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41815)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1XPPrN-0008ML-Lz
	for qemu-devel@nongnu.org; Thu, 04 Sep 2014 01:45:38 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1XPPrE-0003Yq-BY
	for qemu-devel@nongnu.org; Thu, 04 Sep 2014 01:45:29 -0400
Received: from mail-we0-x235.google.com ([2a00:1450:400c:c03::235]:42583)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1XPPrE-0003YT-4u
	for qemu-devel@nongnu.org; Thu, 04 Sep 2014 01:45:20 -0400
Received: by mail-we0-f181.google.com with SMTP id x48so9737013wes.12
	for <qemu-devel@nongnu.org>; Wed, 03 Sep 2014 22:45:19 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <5407FC69.3040200@redhat.com>
Date: Thu, 04 Sep 2014 07:45:13 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1409743435-21155-1-git-send-email-famz@redhat.com>	<1409743435-21155-5-git-send-email-famz@redhat.com>	<5406FB57.7070900@redhat.com>
	<20140904012059.GC3760@T430.nay.redhat.com>
In-Reply-To: <20140904012059.GC3760@T430.nay.redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v4 04/20] block: Convert
 bdrv_em_aiocb_info.cancel to .cancel_async
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Chrysostomos Nanakos <cnanakos@grnet.gr>, Ronnie Sahlberg <ronniesahlberg@gmail.com>, Peter Lieven <pl@kamp.de>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>, Josh Durgin <josh.durgin@inktank.com>, Liu Yuan <namei.unix@gmail.com>, MORITA Kazutaka <morita.kazutaka@lab.ntt.co.jp>, Benoit Canet <benoit@irqsave.net>

Il 04/09/2014 03:20, Fam Zheng ha scritto:
>> > 
>> > This requires auditing all callbacks though, doesn't it?  Or at least
>> > adding an
>> > 
>> >     if (ret == -ECANCELED) {
>> >         return;
>> >     }
>> > 
>> > at the beginning.
> You are right, this is an unexpected error code for ide at least.

Yeahh, I think it's IDE only.

It is fine for SCSI which is already testing io_canceled.  It should not
matter (or it could even help) for NVME.

Paolo