From: Eric Blake <eblake@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: mdroth@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH] tests: Use error_free_or_abort() where appropriate
Date: Fri, 17 Feb 2017 14:39:00 -0600 [thread overview]
Message-ID: <5407a810-b21d-8551-c8b8-01a6582e3c0e@redhat.com> (raw)
In-Reply-To: <1487362554-5688-1-git-send-email-armbru@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 714 bytes --]
On 02/17/2017 02:15 PM, Markus Armbruster wrote:
> Done with this Coccinelle semantic patch:
>
> @@
> expression E;
> @@
> - g_assert(E);
> - error_free(E);
> + error_free_or_abort(&E);
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> tests/test-qemu-opts.c | 3 +--
> tests/test-qobject-output-visitor.c | 6 ++----
> 2 files changed, 3 insertions(+), 6 deletions(-)
Nice that it doesn't find many uses (it means we've already swept the
tests for this pattern manually).
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
prev parent reply other threads:[~2017-02-17 20:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-17 20:15 [Qemu-devel] [PATCH] tests: Use error_free_or_abort() where appropriate Markus Armbruster
2017-02-17 20:39 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5407a810-b21d-8551-c8b8-01a6582e3c0e@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).