From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56167) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XPnhW-0000bd-4O for qemu-devel@nongnu.org; Fri, 05 Sep 2014 03:13:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XPnhL-0000Rq-7y for qemu-devel@nongnu.org; Fri, 05 Sep 2014 03:12:54 -0400 Message-ID: <5409626A.1010901@suse.de> Date: Fri, 05 Sep 2014 09:12:42 +0200 From: Alexander Graf MIME-Version: 1.0 References: <1409246113-6519-1-git-send-email-pbonzini@redhat.com> <1409246113-6519-7-git-send-email-pbonzini@redhat.com> <54075DBD.9000800@gmail.com> In-Reply-To: <54075DBD.9000800@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH 06/17] ppc: use CRF_* in int_helper.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Tom Musta , Paolo Bonzini , qemu-devel@nongnu.org Cc: dgibson@redhat.com, qemu-ppc@nongnu.org On 03.09.14 20:28, Tom Musta wrote: > On 8/28/2014 12:15 PM, Paolo Bonzini wrote: >> Signed-off-by: Paolo Bonzini >> --- >> target-ppc/int_helper.c | 12 ++++++------ >> 1 file changed, 6 insertions(+), 6 deletions(-) >> >> diff --git a/target-ppc/int_helper.c b/target-ppc/int_helper.c >> index f6e8846..9c1c5cd 100644 >> --- a/target-ppc/int_helper.c >> +++ b/target-ppc/int_helper.c >> @@ -2303,25 +2303,25 @@ uint32_t helper_bcdadd(ppc_avr_t *r, ppc_avr_t *a, ppc_avr_t *b, uint32_t ps) >> if (sgna == sgnb) { >> result.u8[BCD_DIG_BYTE(0)] = bcd_preferred_sgn(sgna, ps); >> zero = bcd_add_mag(&result, a, b, &invalid, &overflow); >> - cr = (sgna > 0) ? 4 : 8; >> + cr = (sgna > 0) ? 1 << CRF_GT : 1 << CRF_LT; >> } else if (bcd_cmp_mag(a, b) > 0) { >> result.u8[BCD_DIG_BYTE(0)] = bcd_preferred_sgn(sgna, ps); >> zero = bcd_sub_mag(&result, a, b, &invalid, &overflow); >> - cr = (sgna > 0) ? 4 : 8; >> + cr = (sgna > 0) ? 1 << CRF_GT : 1 << CRF_LT; >> } else { >> result.u8[BCD_DIG_BYTE(0)] = bcd_preferred_sgn(sgnb, ps); >> zero = bcd_sub_mag(&result, b, a, &invalid, &overflow); >> - cr = (sgnb > 0) ? 4 : 8; >> + cr = (sgnb > 0) ? 1 << CRF_GT : 1 << CRF_LT; >> } >> } >> >> if (unlikely(invalid)) { >> result.u64[HI_IDX] = result.u64[LO_IDX] = -1; >> - cr = 1; >> + cr = 1 << CRF_SO; >> } else if (overflow) { >> - cr |= 1; >> + cr |= 1 << CRF_SO; >> } else if (zero) { >> - cr = 2; >> + cr = 1 << CRF_EQ; >> } >> >> *r = result; >> > > Reviewed-by: Tom Musta > Tested-by: Tom Musta Thanks, applied to ppc-next. Alex