From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59676) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XPnuZ-0005QG-Vh for qemu-devel@nongnu.org; Fri, 05 Sep 2014 03:26:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XPnuS-0004vz-GN for qemu-devel@nongnu.org; Fri, 05 Sep 2014 03:26:23 -0400 Message-ID: <54096597.1020408@suse.de> Date: Fri, 05 Sep 2014 09:26:15 +0200 From: Alexander Graf MIME-Version: 1.0 References: <1409246113-6519-1-git-send-email-pbonzini@redhat.com> <1409246113-6519-8-git-send-email-pbonzini@redhat.com> <54075DC4.50705@gmail.com> In-Reply-To: <54075DC4.50705@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH 07/17] ppc: fix result of DLMZB when no zero bytes are found List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Tom Musta , Paolo Bonzini , qemu-devel@nongnu.org Cc: dgibson@redhat.com, qemu-ppc@nongnu.org On 03.09.14 20:28, Tom Musta wrote: > On 8/28/2014 12:15 PM, Paolo Bonzini wrote: >> It must return 8 and place 8 in XER, but the current code uses >> i directly which is 9 at this point of the code. >> >> Signed-off-by: Paolo Bonzini >> --- >> target-ppc/int_helper.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/target-ppc/int_helper.c b/target-ppc/int_helper.c >> index 9c1c5cd..7955bf7 100644 >> --- a/target-ppc/int_helper.c >> +++ b/target-ppc/int_helper.c >> @@ -2573,6 +2573,7 @@ target_ulong helper_dlmzb(CPUPPCState *env, target_ulong high, >> } >> i++; >> } >> + i = 8; >> if (update_Rc) { >> env->crf[0] = 0x2; >> } >> > > Reviewed-by: Tom Musta Thanks, applied to ppc-next. Alex