From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36468) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XPoOY-00058c-NR for qemu-devel@nongnu.org; Fri, 05 Sep 2014 03:57:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XPoOP-0005XM-Lc for qemu-devel@nongnu.org; Fri, 05 Sep 2014 03:57:22 -0400 Received: from e8.ny.us.ibm.com ([32.97.182.138]:34373) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XPoOP-0005X6-GP for qemu-devel@nongnu.org; Fri, 05 Sep 2014 03:57:13 -0400 Received: from /spool/local by e8.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 5 Sep 2014 03:57:12 -0400 Message-ID: <54096C9F.1070602@linux.vnet.ibm.com> Date: Fri, 05 Sep 2014 13:26:15 +0530 From: Aravinda Prasad MIME-Version: 1.0 References: <20140904111153.20476.58429.stgit@aravindap> <20140904111328.20476.51234.stgit@aravindap> <5409695C.3020401@suse.de> In-Reply-To: <5409695C.3020401@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 1/4] target-ppc: Extend rtas-blob List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: benh@au1.ibm.com, aik@au1.ibm.com, qemu-devel@nongnu.org, qemu-ppc@nongnu.org, paulus@samba.org On Friday 05 September 2014 01:12 PM, Alexander Graf wrote: > > > On 04.09.14 13:13, Aravinda Prasad wrote: >> Extend rtas-blob to accommodate error log. Error log >> structure is saved in rtas space upon a machine check >> exception. >> >> Signed-off-by: Aravinda Prasad >> --- >> hw/ppc/spapr.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c >> index 4b20e36..4a7c0ae 100644 >> --- a/hw/ppc/spapr.c >> +++ b/hw/ppc/spapr.c >> @@ -1409,6 +1409,10 @@ static void ppc_spapr_init(MachineState *machine) >> >> filename = qemu_find_file(QEMU_FILE_TYPE_BIOS, "spapr-rtas.bin"); >> spapr->rtas_size = get_image_size(filename); >> + >> + /* Resize blob to accommodate error log at a page aligned address */ >> + spapr->rtas_size = TARGET_PAGE_ALIGN(spapr->rtas_size) + TARGET_PAGE_SIZE; > > I think it's clearer if you do > > #define RTAS_ERROR_LOG_SIZE 4096 > > and add this to the aligned size instead. sure > > > Alex > -- Regards, Aravinda