From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42874) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XPp1Q-0003ua-3y for qemu-devel@nongnu.org; Fri, 05 Sep 2014 04:37:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XPp1I-0002qm-Jy for qemu-devel@nongnu.org; Fri, 05 Sep 2014 04:37:32 -0400 Received: from cantor2.suse.de ([195.135.220.15]:53095 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XPp1I-0002qg-D5 for qemu-devel@nongnu.org; Fri, 05 Sep 2014 04:37:24 -0400 Message-ID: <54097643.30507@suse.de> Date: Fri, 05 Sep 2014 10:37:23 +0200 From: Alexander Graf MIME-Version: 1.0 References: <20140904105223.336503578@de.ibm.com> <20140904105337.202077766@de.ibm.com> In-Reply-To: <20140904105337.202077766@de.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC][patch 4/6] KVM: s390: Add PCI pass-through support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: frank.blaschka@de.ibm.com, qemu-devel@nongnu.org, linux-s390@vger.kernel.org, kvm@vger.kernel.org Cc: aik@ozlabs.ru, pbonzini@redhat.com On 04.09.14 12:52, frank.blaschka@de.ibm.com wrote: > From: Frank Blaschka > > This patch implemets PCI pass-through kernel support for s390. > Design approach is very similar to the x86 device assignment. > User space executes the KVM_ASSIGN_PCI_DEVICE ioctl to create > a proxy instance in the kernel KVM and connect this instance to the > host pci device. s390 pci instructions are intercepted in kernel and > operations are passed directly to the assigned pci device. > To take advantage of all system z specific virtualization features > we need to access the SIE control block residing in KVM. Also we have to > enable z pci devices with special configuration information coming > form the SIE block as well. > > Signed-off-by: Frank Blaschka > --- > arch/s390/include/asm/kvm_host.h | 1 > arch/s390/kvm/Makefile | 2 > arch/s390/kvm/intercept.c | 1 > arch/s390/kvm/kvm-s390.c | 33 > arch/s390/kvm/kvm-s390.h | 17 > arch/s390/kvm/pci.c | 2130 +++++++++++++++++++++++++++++++++++++++ > arch/s390/kvm/priv.c | 21 > 7 files changed, 2202 insertions(+), 3 deletions(-) I would love to review this patch, but in its current form it's impossible to do. I can't possibly keep > 2000 lines of code in my head. Alex