qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Claudio Fontana <claudio.fontana@huawei.com>
To: "Michael S. Tsirkin" <mst@redhat.com>,
	David Marchand <david.marchand@6wind.com>
Cc: Olivier Matz <olivier.matz@6wind.com>,
	kvm@vger.kernel.org, stefanha@gmail.com, armbru@redhat.com,
	qemu-devel@nongnu.org, arei.gonglei@huawei.com,
	mkletzan@redhat.com, pbonzini@redhat.com,
	jani.kokkonen@huawei.com, cam@cs.ualberta.ca
Subject: Re: [Qemu-devel] [PATCH v5 1/3] contrib: add ivshmem client and server
Date: Fri, 5 Sep 2014 10:52:53 +0200	[thread overview]
Message-ID: <540979E5.1010303@huawei.com> (raw)
In-Reply-To: <20140904155657.GD21203@redhat.com>

Just to point out that for the client there is also a DEBUG_LOG to uppercase, just like already pointed out for the server.

>> diff --git a/contrib/ivshmem-client/ivshmem-client.c b/contrib/ivshmem-client/ivshmem-client.c
>> new file mode 100644
>> index 0000000..ad210c8
>> --- /dev/null
>> +++ b/contrib/ivshmem-client/ivshmem-client.c
>> @@ -0,0 +1,405 @@
>> +/*
>> + * Copyright 6WIND S.A., 2014
>> + *
>> + * This work is licensed under the terms of the GNU GPL, version 2 or
>> + * (at your option) any later version.  See the COPYING file in the
>> + * top-level directory.
>> + */
>> +
>> +#include <sys/types.h>
>> +#include <sys/socket.h>
>> +#include <sys/un.h>
>> +
>> +#include "qemu-common.h"
>> +#include "qemu/queue.h"
>> +
>> +#include "ivshmem-client.h"
>> +
>> +/* log a message on stdout if verbose=1 */
>> +#define debug_log(client, fmt, ...) do { \
>> +        if ((client)->verbose) {         \
>> +            printf(fmt, ## __VA_ARGS__); \
>> +        }                                \
>> +    } while (0)
>> +

..here (DEBUG_LOG?)

Thanks to all who are working on this.

Claudio

  reply	other threads:[~2014-09-05  8:53 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-04 12:50 [Qemu-devel] [PATCH v5 0/3] ivshmem: update documentation, add client/server tools David Marchand
2014-09-04 12:50 ` [Qemu-devel] [PATCH v5 1/3] contrib: add ivshmem client and server David Marchand
2014-09-04 15:56   ` Michael S. Tsirkin
2014-09-05  8:52     ` Claudio Fontana [this message]
2014-09-05 12:07     ` David Marchand
2014-09-07  5:58       ` Michael S. Tsirkin
2014-09-04 15:58   ` Michael S. Tsirkin
2014-09-05 10:40   ` Stefan Hajnoczi
2014-09-04 12:51 ` [Qemu-devel] [PATCH v5 2/3] docs: update ivshmem device spec David Marchand
2014-09-05 10:30   ` Stefan Hajnoczi
2014-09-04 12:51 ` [Qemu-devel] [PATCH v5 3/3] ivshmem: add check on protocol version in QEMU David Marchand
2014-09-05 10:29   ` Stefan Hajnoczi
2014-09-05 12:25     ` David Marchand
2014-09-08  8:30       ` Stefan Hajnoczi
2014-09-04 15:40 ` [Qemu-devel] [PATCH v5 0/3] ivshmem: update documentation, add client/server tools Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=540979E5.1010303@huawei.com \
    --to=claudio.fontana@huawei.com \
    --cc=arei.gonglei@huawei.com \
    --cc=armbru@redhat.com \
    --cc=cam@cs.ualberta.ca \
    --cc=david.marchand@6wind.com \
    --cc=jani.kokkonen@huawei.com \
    --cc=kvm@vger.kernel.org \
    --cc=mkletzan@redhat.com \
    --cc=mst@redhat.com \
    --cc=olivier.matz@6wind.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).