From: Alexander Graf <agraf@suse.de>
To: Bogdan Purcareata <bogdan.purcareata@freescale.com>, qemu-ppc@nongnu.org
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH 0/2] PPC: kvm: Fix incorrect remapping of in-kernel MPIC
Date: Fri, 05 Sep 2014 11:07:48 +0200 [thread overview]
Message-ID: <54097D64.8010506@suse.de> (raw)
In-Reply-To: <1409769375-22286-1-git-send-email-bogdan.purcareata@freescale.com>
On 03.09.14 20:36, Bogdan Purcareata wrote:
> On target-ppc, the kvm-openpic memory region is part of the E500-CCSR memory
> region. On the kernel side, the MPIC is mapped at the same offset as the
> kvm-openpic within the address space.
>
> When adding the PCI BAR0 memory region, an alias is created to point to the
> E500-CCSR memory region. This results in firing the kvm_openpic_region_add once
> more, since kvm-openpic is part of the latter. Only this time, the offset is
> wrong - it's part of the PCI memory region. This leads to the in-kernel MPIC to
> be remapped at a wrong address, and thus all traps to the kvm-openpic
> address to be emulated in userspace.
>
> The fix consists in an additional filter in kvm_openpic_region_{add,del} to
> consider only addresses matching the start of the kvm-openpic memory region.
If this is true, wouldn't vhost and vfio be broken too?
Alex
next prev parent reply other threads:[~2014-09-05 9:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-03 18:36 [Qemu-devel] [PATCH 0/2] PPC: kvm: Fix incorrect remapping of in-kernel MPIC Bogdan Purcareata
2014-09-03 18:36 ` [Qemu-devel] [PATCH 1/2] memory: Add MemoryRegion get address space offset helper function Bogdan Purcareata
2014-09-05 15:31 ` [Qemu-devel] [Qemu-ppc] " Scott Wood
2014-09-03 18:36 ` [Qemu-devel] [PATCH 2/2] PPC: openpic_kvm: Filter region callbacks based on memory region offset Bogdan Purcareata
2014-09-05 15:47 ` [Qemu-devel] [Qemu-ppc] " Scott Wood
2014-09-10 11:40 ` bogdan.purcareata
2014-09-10 13:56 ` Alexander Graf
2014-09-11 10:14 ` bogdan.purcareata
2014-09-11 10:27 ` Alexander Graf
2014-09-05 9:07 ` Alexander Graf [this message]
2014-09-05 9:08 ` [Qemu-devel] [Qemu-ppc] [PATCH 0/2] PPC: kvm: Fix incorrect remapping of in-kernel MPIC Alexander Graf
2014-09-05 12:59 ` mihai.caraman
2014-09-05 14:31 ` mihai.caraman
2014-09-10 12:49 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54097D64.8010506@suse.de \
--to=agraf@suse.de \
--cc=bogdan.purcareata@freescale.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).