From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49285) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XPuVw-0004cl-Hu for qemu-devel@nongnu.org; Fri, 05 Sep 2014 10:29:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XPuVq-0003NE-AI for qemu-devel@nongnu.org; Fri, 05 Sep 2014 10:29:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:64996) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XPuVq-0003N8-2g for qemu-devel@nongnu.org; Fri, 05 Sep 2014 10:29:18 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s85ETG4M024321 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Fri, 5 Sep 2014 10:29:16 -0400 Message-ID: <5409C8BB.2010108@redhat.com> Date: Fri, 05 Sep 2014 08:29:15 -0600 From: Eric Blake MIME-Version: 1.0 References: <1409926039-29044-1-git-send-email-mreitz@redhat.com> <1409926039-29044-2-git-send-email-mreitz@redhat.com> In-Reply-To: <1409926039-29044-2-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="9qARfL9bxrU9202VR02KukTSI9xESErgr" Subject: Re: [Qemu-devel] [PATCH v2 1/5] qapi/block: Add "fatal" to BLOCK_IMAGE_CORRUPTED List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --9qARfL9bxrU9202VR02KukTSI9xESErgr Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 09/05/2014 08:07 AM, Max Reitz wrote: > Not every BLOCK_IMAGE_CORRUPTED event must be fatal; for example, when > reading from an image, they should generally not be. Nonetheless, even > an image only read from may of course be corrupted and this can be > detected during normal operation. In this case, a non-fatal event shoul= d > be emitted, but the image should not be marked corrupt (in accordance t= o > "fatal" set to false). >=20 > Signed-off-by: Max Reitz > --- > block/qcow2-refcount.c | 1 + > qapi/block-core.json | 9 +++++++-- > 2 files changed, 8 insertions(+), 2 deletions(-) As this is purely additive, it should not break any former clients. Older clients not knowing to look for the fatal flag will treat everything as fatal, but that's okay. Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --9qARfL9bxrU9202VR02KukTSI9xESErgr Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUCci7AAoJEKeha0olJ0Nq8bUH/1qb+4j2Nd8hBFsd/kyMLkrZ HTnOYM+H2j8vGKn5ZPvnUlNWPhC2On8yG1r70a6u8Jw1//GAJfZDdAnjelapZc+p 592xo8j3rxn1ksL/fY9btGCKKTF8zLjqAnw719P/S/HnBaWIeGwsLgxc59sAUG82 wanx5SBahPrsQtrWyTr0jasSGXv8+uiYRwM1+u9T0mOKEmYgEmLTO8b6bfNCtOG5 xBYLUiCr5vzivPHtOG4GJQnZK0PsQS/1fPf7p9c7G7nM5XASmqNV67I/fDkMccq/ HP7PNH2rM/TOUW9xA+58u4Iu5kHe5zYoTL9+fz0jk6o7lli0Jup/NK/O2V4HvVo= =lKvH -----END PGP SIGNATURE----- --9qARfL9bxrU9202VR02KukTSI9xESErgr--