From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52024) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XPugg-0003mr-EH for qemu-devel@nongnu.org; Fri, 05 Sep 2014 10:40:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XPugZ-0007YQ-Ii for qemu-devel@nongnu.org; Fri, 05 Sep 2014 10:40:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54346) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XPugZ-0007YK-Au for qemu-devel@nongnu.org; Fri, 05 Sep 2014 10:40:23 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s85EeMJm024838 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Fri, 5 Sep 2014 10:40:22 -0400 Message-ID: <5409CB55.9000401@redhat.com> Date: Fri, 05 Sep 2014 08:40:21 -0600 From: Eric Blake MIME-Version: 1.0 References: <1409926039-29044-1-git-send-email-mreitz@redhat.com> <1409926039-29044-2-git-send-email-mreitz@redhat.com> In-Reply-To: <1409926039-29044-2-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="hftSmXfADe6hVtdVp1ereQaSdx3vWc08L" Subject: Re: [Qemu-devel] [PATCH v2 1/5] qapi/block: Add "fatal" to BLOCK_IMAGE_CORRUPTED List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --hftSmXfADe6hVtdVp1ereQaSdx3vWc08L Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 09/05/2014 08:07 AM, Max Reitz wrote: > Not every BLOCK_IMAGE_CORRUPTED event must be fatal; for example, when > reading from an image, they should generally not be. Nonetheless, even > an image only read from may of course be corrupted and this can be > detected during normal operation. In this case, a non-fatal event shoul= d > be emitted, but the image should not be marked corrupt (in accordance t= o > "fatal" set to false). >=20 Question - what happens if management misses the signal? For example, if libvirt opens qemu on a read-only image, then goes away, then corruption is detected, then libvirt reconnects. Does query-block need to also be updated to report whether a read-only BDS is currently detected as fatal, but that an event has already been delivered? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --hftSmXfADe6hVtdVp1ereQaSdx3vWc08L Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUCctVAAoJEKeha0olJ0NqbisH+wRRR7HQ1c67U8pNYiY1yr7o 1k1FEsWfPFUFmTJm3tgV43OLsnUDlBHSRYmH8zJ3xL5OFGhE92hcXfb5hPl3iI0j eyTz8pOqpu0wYDciM3ZX1BPtE3lJHtqp3ZX0j0ZyT2t0EaCjdpOHzYgshz72/TQ+ zaIOH0zzfV6tZFve9hehNiX2BxzfoBvsGTN95mVzNT1HknxIBPDYmanoASdTojVR lfW45/OUA7o+PzDtsUpJrrOW49/hbzMz7JyDQy/SM7C7TbVpL3brTy9Ch97ogWxQ 8JxQR9RnzL0JMUXInXfnf71Yd2VbxU2zSvEe15CnwmjxA77H705I3aN8YGS6MLI= =Xwvh -----END PGP SIGNATURE----- --hftSmXfADe6hVtdVp1ereQaSdx3vWc08L--