From: Peter Lieven <pl@kamp.de>
To: ronnie sahlberg <ronniesahlberg@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>,
Stefan Hajnoczi <stefanha@redhat.com>,
Max Reitz <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/4] introduce max_transfer_length
Date: Fri, 05 Sep 2014 21:52:04 +0200 [thread overview]
Message-ID: <540A1464.2060003@kamp.de> (raw)
In-Reply-To: <CAN05THTn5s7kwoeoXpffQNb1JZsqAGO100K7i_VmxZQ-nia7Eg@mail.gmail.com>
Am 05.09.2014 um 19:05 schrieb ronnie sahlberg:
> Looks good to me.
>
> (minor question is just why not let default max be 0xffff for both 10
> and 16 CDBs ?)
You are right. I was looking at the technical limit, but in fact it doesn't
make sense to have different limits. Its ridiculous to say, you wan't to
do big I/O then you need a target thats bigger than 2TB ;-)
Peter
>
> On Fri, Sep 5, 2014 at 9:51 AM, Peter Lieven <pl@kamp.de> wrote:
>> This series adds the basics for introducing a maximum transfer length
>> to the block layer. Its main purpose is currently avoiding that
>> a multiwrite_merge exceeds the max_xfer_len of an attached iSCSI LUN.
>> This is a required bug fix.
>>
>> Discussed reporting of this maximum in the SCSI Disk Inquiry Emulation
>> of the Block Limits VPD is currently not added as we do not import any
>> of the other limits there. This has to be addresses in a seperate series.
>>
>> Peter Lieven (4):
>> BlockLimits: introduce max_transfer_length
>> block: immediate cancel oversized read/write requests
>> block/iscsi: set max_transfer_length
>> block: avoid creating oversized writes in multiwrite_merge
>>
>> block.c | 23 +++++++++++++++++++++++
>> block/iscsi.c | 12 ++++++++++--
>> include/block/block_int.h | 3 +++
>> 3 files changed, 36 insertions(+), 2 deletions(-)
>>
>> --
>> 1.7.9.5
>>
next prev parent reply other threads:[~2014-09-05 19:52 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-05 16:51 [Qemu-devel] [PATCH 0/4] introduce max_transfer_length Peter Lieven
2014-09-05 16:51 ` [Qemu-devel] [PATCH 1/4] BlockLimits: " Peter Lieven
2014-09-05 16:51 ` [Qemu-devel] [PATCH 2/4] block: immediately cancel oversized read/write requests Peter Lieven
2014-09-08 13:44 ` Benoît Canet
2014-09-08 13:49 ` Paolo Bonzini
2014-09-08 13:56 ` Peter Lieven
2014-09-08 13:58 ` Paolo Bonzini
2014-09-08 14:35 ` Peter Lieven
2014-09-08 14:42 ` Paolo Bonzini
2014-09-08 14:54 ` Peter Lieven
2014-09-23 8:47 ` Kevin Wolf
2014-09-23 8:55 ` Peter Lieven
2014-09-23 9:09 ` Kevin Wolf
2014-09-08 15:13 ` ronnie sahlberg
2014-09-08 15:15 ` Paolo Bonzini
2014-09-08 15:18 ` Peter Lieven
2014-09-08 15:27 ` Paolo Bonzini
2014-09-08 16:18 ` Peter Lieven
2014-09-08 16:29 ` Paolo Bonzini
2014-09-12 11:43 ` Peter Lieven
2014-09-18 14:12 ` Paolo Bonzini
2014-09-18 14:16 ` Peter Lieven
2014-09-18 14:17 ` Paolo Bonzini
2014-09-18 22:57 ` Peter Lieven
2014-09-08 15:16 ` Peter Lieven
2014-09-05 16:51 ` [Qemu-devel] [PATCH 3/4] block/iscsi: set max_transfer_length Peter Lieven
2014-09-05 16:51 ` [Qemu-devel] [PATCH 4/4] block: avoid creating oversized writes in multiwrite_merge Peter Lieven
2014-09-18 14:13 ` Paolo Bonzini
2014-09-18 22:56 ` Peter Lieven
2014-09-19 13:33 ` Paolo Bonzini
2014-09-22 9:43 ` Peter Lieven
2014-09-22 19:06 ` Paolo Bonzini
2014-09-23 6:15 ` Peter Lieven
2014-09-23 8:59 ` Kevin Wolf
2014-09-23 9:04 ` Peter Lieven
2014-09-23 9:32 ` Peter Lieven
2014-09-23 9:47 ` Kevin Wolf
2014-09-23 9:52 ` Peter Lieven
2014-09-23 10:05 ` Kevin Wolf
2014-09-30 7:26 ` Peter Lieven
2014-09-30 8:03 ` Kevin Wolf
2014-09-05 17:05 ` [Qemu-devel] [PATCH 0/4] introduce max_transfer_length ronnie sahlberg
2014-09-05 19:52 ` Peter Lieven [this message]
2014-09-05 21:22 ` ronnie sahlberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=540A1464.2060003@kamp.de \
--to=pl@kamp.de \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=ronniesahlberg@gmail.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).