From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47931) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XQzSa-0003lb-EJ for qemu-devel@nongnu.org; Mon, 08 Sep 2014 09:58:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XQzSU-0004TA-AY for qemu-devel@nongnu.org; Mon, 08 Sep 2014 09:58:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56587) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XQzSU-0004T0-49 for qemu-devel@nongnu.org; Mon, 08 Sep 2014 09:58:18 -0400 Message-ID: <540DB5EB.2070705@redhat.com> Date: Mon, 08 Sep 2014 15:58:03 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1409935888-18552-1-git-send-email-pl@kamp.de> <1409935888-18552-3-git-send-email-pl@kamp.de> <20140908134434.GB22582@irqsave.net> <540DB3E2.6010905@redhat.com> <540DB583.4030101@kamp.de> In-Reply-To: <540DB583.4030101@kamp.de> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/4] block: immediately cancel oversized read/write requests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Lieven , =?windows-1252?Q?Beno=EEt_Canet?= Cc: kwolf@redhat.com, ronniesahlberg@gmail.com, qemu-devel@nongnu.org, stefanha@redhat.com, mreitz@redhat.com Il 08/09/2014 15:56, Peter Lieven ha scritto: >>>>> >>> Look like you are changing the coroutine version. >>> >>> Some hardware like virtio-blk uses the AIO version of read and writes. >>> What would happen if all the block drivers down the chain are AIO >>> enabled ? >> The AIO version still goes through bdrv_co_do_readv/writev. >> >> However, error_report is not something you can use for guest-accessible >> error messages, unless you want your logs to fill up with error >> messages. :) > > So you would not throw an error msg here? No, though a trace could be useful. Paolo