From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35937) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XR0gj-0005y2-5e for qemu-devel@nongnu.org; Mon, 08 Sep 2014 11:17:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XR0ge-0004OD-Jr for qemu-devel@nongnu.org; Mon, 08 Sep 2014 11:17:05 -0400 Received: from lhrrgout.huawei.com ([194.213.3.17]:55772) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XR0ge-0004MZ-C5 for qemu-devel@nongnu.org; Mon, 08 Sep 2014 11:17:00 -0400 Message-ID: <540DC84E.4010402@huawei.com> Date: Mon, 8 Sep 2014 17:16:30 +0200 From: Claudio Fontana MIME-Version: 1.0 References: <1409762817-24029-1-git-send-email-rth@twiddle.net> <1409762817-24029-2-git-send-email-rth@twiddle.net> In-Reply-To: <1409762817-24029-2-git-send-email-rth@twiddle.net> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/2] tcg: Compress TCGLabelQemuLdst List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson , qemu-devel@nongnu.org Reviewed-by: Claudio Fontana On 03.09.2014 18:46, Richard Henderson wrote: > Use 1 32-bit word instead of 6. > > Signed-off-by: Richard Henderson > --- > tcg/tcg-be-ldst.h | 19 ++++++++++++------- > 1 file changed, 12 insertions(+), 7 deletions(-) > > diff --git a/tcg/tcg-be-ldst.h b/tcg/tcg-be-ldst.h > index 49b3de6..904eeda 100644 > --- a/tcg/tcg-be-ldst.h > +++ b/tcg/tcg-be-ldst.h > @@ -23,14 +23,19 @@ > #ifdef CONFIG_SOFTMMU > #define TCG_MAX_QEMU_LDST 640 > > +QEMU_BUILD_BUG_ON(TCG_TARGET_NB_REGS > 32); > +QEMU_BUILD_BUG_ON(NB_MMU_MODES > 8); > + > typedef struct TCGLabelQemuLdst { > - bool is_ld:1; /* qemu_ld: true, qemu_st: false */ > - TCGMemOp opc:4; > - TCGReg addrlo_reg; /* reg index for low word of guest virtual addr */ > - TCGReg addrhi_reg; /* reg index for high word of guest virtual addr */ > - TCGReg datalo_reg; /* reg index for low word to be loaded or stored */ > - TCGReg datahi_reg; /* reg index for high word to be loaded or stored */ > - int mem_index; /* soft MMU memory index */ > + TCGMemOp opc : 4; > + bool is_ld : 1; /* qemu_ld: true, qemu_st: false */ > + TCGReg addrlo_reg : 5; /* reg index for low word of guest virtual addr */ > + TCGReg addrhi_reg : 5; /* reg index for high word of guest virtual addr */ > + TCGReg datalo_reg : 5; /* reg index for low word to be loaded or stored */ > + TCGReg datahi_reg : 5; /* reg index for high word to be loaded or stored */ > + unsigned mem_index : 3; /* soft MMU memory index */ > + /* 4 bits unused in 32-bit word */ > + > tcg_insn_unit *raddr; /* gen code addr of the next IR of qemu_ld/st IR */ > tcg_insn_unit *label_ptr[2]; /* label pointers to be updated */ > } TCGLabelQemuLdst; >