From: Eric Blake <eblake@redhat.com>
To: Luiz Capitulino <lcapitulino@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>
Cc: peter.maydell@linaro.org, mtosatti@redhat.com, qemu-stable@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] exec: file_ram_alloc(): print error when prealloc fails
Date: Mon, 08 Sep 2014 13:28:50 -0600 [thread overview]
Message-ID: <540E0372.9060901@redhat.com> (raw)
In-Reply-To: <20140908140826.3a673423@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 777 bytes --]
On 09/08/2014 12:08 PM, Luiz Capitulino wrote:
> If memory allocation fails when using the -mem-prealloc command-line
> option, QEMU exits without printing any error information to
> the user:
>
> # qemu [...] -m 1G -mem-prealloc -mem-path /dev/hugepages
> # echo $?
> 1
>
> This commit adds an error message, so that we print instead:
>
> # qemu [...] -m 1G -mem-prealloc -mem-path /dev/hugepages
> qemu: unable to map backing store for hugepages: Cannot allocate memory
>
> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
> ---
> exec.c | 1 +
> 1 file changed, 1 insertion(+)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]
prev parent reply other threads:[~2014-09-08 19:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-08 18:08 [Qemu-devel] [PATCH] exec: file_ram_alloc(): print error when prealloc fails Luiz Capitulino
2014-09-08 19:28 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=540E0372.9060901@redhat.com \
--to=eblake@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=mtosatti@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).