From: Jason Wang <jasowang@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>,
Stefan Hajnoczi <stefanha@gmail.com>
Cc: "Markus Armbruster" <armbru@redhat.com>,
"Andreas Färber" <afaerber@suse.de>,
qemu-devel <qemu-devel@nongnu.org>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] net: don't use set/get_pointer() in set/get_netdev()
Date: Tue, 09 Sep 2014 11:03:02 +0800 [thread overview]
Message-ID: <540E6DE6.2060704@redhat.com> (raw)
In-Reply-To: <CAFEAcA8cVkTEmL6L+PyNce+8MpKvQ9HeYLQrL0pfhrLyAQRSag@mail.gmail.com>
On 09/05/2014 12:40 AM, Peter Maydell wrote:
> On 4 September 2014 17:21, Stefan Hajnoczi <stefanha@gmail.com> wrote:
>> Unfortunately this patch breaks aarch64-softmmu qtests:
>> GTESTER check-qtest-aarch64
>> Broken pipe
>> GTester: last random seed: R02S6d8ab263ca56f8ae7a4b47bdf93fbc73
>>
>> Please take a look at what is causing this.
> Specifically, it breaks on all the ARM boards which have
> more than one built in ethernet device. Something in your
> patch is probably assuming there is only one (there's
> a somewhat suspicious "[0]" array reference, for instance).
>
> thanks
> -- PMM
>
The '[0]' dereference was introduced after multiqueue is supported.
Since there may be multiple pairs of peers for each nic.
The failure reason looks like the ncs[0] pointer should be validated
before trying to access them.
Will post V2.
Thanks
next prev parent reply other threads:[~2014-09-09 3:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-28 7:41 [Qemu-devel] [PATCH] net: don't use set/get_pointer() in set/get_netdev() Jason Wang
2014-09-02 10:38 ` Stefan Hajnoczi
2014-09-04 16:21 ` Stefan Hajnoczi
2014-09-04 16:40 ` Peter Maydell
2014-09-09 3:03 ` Jason Wang [this message]
2014-09-09 3:01 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=540E6DE6.2060704@redhat.com \
--to=jasowang@redhat.com \
--cc=afaerber@suse.de \
--cc=armbru@redhat.com \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).