From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37581) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XRFKy-0005Bn-QU for qemu-devel@nongnu.org; Tue, 09 Sep 2014 02:55:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XRFDh-000412-R2 for qemu-devel@nongnu.org; Tue, 09 Sep 2014 02:48:27 -0400 Received: from mail-we0-x22c.google.com ([2a00:1450:400c:c03::22c]:44399) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XRFDh-00040a-IK for qemu-devel@nongnu.org; Tue, 09 Sep 2014 02:48:05 -0400 Received: by mail-we0-f172.google.com with SMTP id k48so969948wev.17 for ; Mon, 08 Sep 2014 23:48:04 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <540EA29B.10207@redhat.com> Date: Tue, 09 Sep 2014 08:47:55 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1409653457-27863-1-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1409653457-27863-1-git-send-email-peter.maydell@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 0/5] Convert remaining legacy chardevs to QAPI List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , qemu-devel@nongnu.org Cc: Markus Armbruster , Anthony Liguori , patches@linaro.org Il 02/09/2014 12:24, Peter Maydell ha scritto: > This patchset converts the two remaining legacy chardevs > ('socket' and 'udp') to use the new-style parse/kind > mechanisms, and removes all the no-longer-required > legacy machinery. > > Patch 1 was posted to the list back in June > (https://patches.linaro.org/32298/). I've fixed the obvious > bug picked up in code review, and as far as I can tell from > the thread we decided that the blocking/non-blocking > difference between QAPI and legacy wasn't a problem. > > Patch 2 fixes a hole in the functionality of QAPI-described > UDP chardevs, to avoid regressing the commandline functionality > when we convert the UDP backend in patch 3. > > Patch 4 may be easier to review as an ignore-whitespaces > diff (the de-indentation makes the diff a bit awkward). > > Changes v1->v2: > * fixed the has_* values as suggested by Markus > * added patch 5 which renames the _qapi() function now > the legacy version has gone (again, as suggested by > Markus) > > Peter Maydell (5): > qemu-char: Convert socket backend to QAPI > util/qemu-sockets.c: Support specifying IPv4 or IPv6 in socket_dgram() > qemu-char: Convert udp backend to QAPI > qemu-char: Remove register_char_driver() machinery > qemu-char: Rename register_char_driver_qapi() to > register_char_driver() > > backends/baum.c | 2 +- > backends/msmouse.c | 2 +- > backends/testdev.c | 2 +- > include/sysemu/char.h | 3 +- > qemu-char.c | 353 ++++++++++++++++++++++++-------------------------- > spice-qemu-char.c | 8 +- > ui/console.c | 3 +- > util/qemu-sockets.c | 3 +- > 8 files changed, 180 insertions(+), 196 deletions(-) > Hi Peter, are you going to apply these directly? Paolo