From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56044) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XRKfy-0004uc-9Q for qemu-devel@nongnu.org; Tue, 09 Sep 2014 08:37:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XRKft-0005kY-BW for qemu-devel@nongnu.org; Tue, 09 Sep 2014 08:37:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:31896) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XRKft-0005kQ-50 for qemu-devel@nongnu.org; Tue, 09 Sep 2014 08:37:33 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s89CbWAA031901 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Tue, 9 Sep 2014 08:37:32 -0400 Message-ID: <540EF48B.5090705@redhat.com> Date: Tue, 09 Sep 2014 06:37:31 -0600 From: Eric Blake MIME-Version: 1.0 References: <20140829160727.69f66ecd@redhat.com> <20140908104217.48f2354a@redhat.com> <20140908153318.GH4297@noname.redhat.com> <20140908125701.3be785e9@redhat.com> <20140909082733.GD4847@noname.str.redhat.com> In-Reply-To: <20140909082733.GD4847@noname.str.redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="hRSV6sxILbta18j5tumJQvomPemghu2Ju" Subject: Re: [Qemu-devel] [PATCH] block: extend BLOCK_IO_ERROR event with nospace indicator List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , Luiz Capitulino Cc: fromani@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --hRSV6sxILbta18j5tumJQvomPemghu2Ju Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 09/09/2014 02:27 AM, Kevin Wolf wrote: >>> >>> What was our conclusion wrt the human-readable strerror() string for >>> debugging? Didn't we want to add that as well? >> >> I can do it on top of this patch. So, just adding a new field for this= >> is fine? >=20 > I think so. Perhaps we should give it an 'x-' name to make clear that > it's a debugging help and not supposed to be parsed by management tools= =2E > Or would that be abuse of that namespace? I think using x- would be okay for the namespace, but am not sure we need to go that far. We already have other fields without x- that are documented as human-readable only; for example, CommandLineParameterInfo has: # @help: #optional human readable text string, not suitable for parsing. or in our events, QUORUM_REPORT_BAD has: # @error: #optional, error message. Only present on failure. This field # contains a human-readable error message. There are no semantics other # than that the block layer reported an error and clients should = not # try to interpret the error string. So I'd be fine with something as simple as 'message' or 'error'. >=20 > The alternative solution (or actually we could do both) would be to > store it somewhere in bs and put it into query-block. Enhancing query-block in addition to the event makes sense, if it is easy enough to do. At this point, we are talking about debugging aids, so as long as they are documented appropriately, I won't be too fussy. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --hRSV6sxILbta18j5tumJQvomPemghu2Ju Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUDvSLAAoJEKeha0olJ0Nq7o0H/051l/Ic+6hQRsZSGUmYKWMX klFJsfdLIacoe+RM+Wli4kwMzE59jCrlOQk9+ZsW1LfKHi2YdQoLBKS0K+1T4+UK OGI1fCePud8DbqyPpTVnn/zCe4QydnRYfB/WxhTkdEPvq4asREGgykDhFtiK23BK 26c++zOgtmQ6bkCgjlwqZfKBYpjvP8SUWgNmM26S3H6nBiDFF5MX+IkG9TqkhV1F dONNjTuCv0/e51wLg3bM+eexwWkth5j6bZp3k6SV8qoJ15GyYNH/5GM318OiA52A abxqpjl0/k74t6+jRJKqNO4osLIqWRSAI38VkRfa4UWxBgbfRnPT5OGUjdkQ+Eg= =igiR -----END PGP SIGNATURE----- --hRSV6sxILbta18j5tumJQvomPemghu2Ju--