From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44653) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XRP1x-0007UK-1a for qemu-devel@nongnu.org; Tue, 09 Sep 2014 13:16:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XRP1o-00036J-0B for qemu-devel@nongnu.org; Tue, 09 Sep 2014 13:16:36 -0400 Received: from mail-we0-x230.google.com ([2a00:1450:400c:c03::230]:63301) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XRP1n-000362-Ph for qemu-devel@nongnu.org; Tue, 09 Sep 2014 13:16:27 -0400 Received: by mail-we0-f176.google.com with SMTP id q58so4062130wes.7 for ; Tue, 09 Sep 2014 10:16:27 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <540F35E3.7060207@redhat.com> Date: Tue, 09 Sep 2014 19:16:19 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1410265809-27247-1-git-send-email-pbonzini@redhat.com> <1410265809-27247-10-git-send-email-pbonzini@redhat.com> <20140909135424.GA13212@redhat.com> In-Reply-To: <20140909135424.GA13212@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 09/10] piix: do not raise irq while loading vmstate List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: amit.shah@redhat.com, dgilbert@redhat.com, qemu-devel@nongnu.org, Pavel.Dovgaluk@ispras.ru, quintela@redhat.com Il 09/09/2014 15:54, Michael S. Tsirkin ha scritto: > > Hmm I don't understand. > You are removing call to piix3_update_irq_levels > this call is supposed to just sync up bus to > irq level. > > How can this change system state? Saved state > is supposed to already be in sync. i440FX/PIIX3 state is loaded before i8259, so the interrupt will never be in the i8259 ISR. I am not sure why it is a problem for record/replay, but I think it's plausible to consider this a bug. i8259 state should not be affected by the load of PIIX3 state, since i8259 is migrated separately. Paolo