From: Alexander Graf <agraf@suse.de>
To: Marcelo Tosatti <mtosatti@redhat.com>, qemu-devel@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Andrey Korolyov" <andrey@xdel.ru>,
"Marcin GibuÅ?a" <m.gibula@beyond.pl>
Subject: Re: [Qemu-devel] [patch 1/3] kvmclock: Ensure time in migration never goes backward
Date: Tue, 09 Sep 2014 23:16:45 +0200 [thread overview]
Message-ID: <540F6E3D.7090405@suse.de> (raw)
In-Reply-To: <20140909151230.GA3106@amt.cnet>
Who are you pinging?
Alex
On 09.09.14 17:12, Marcelo Tosatti wrote:
> Ping?
>
> On Fri, Sep 05, 2014 at 10:52:45AM -0300, Marcelo Tosatti wrote:
>> From: Alexander Graf <agraf@suse.de>
>>
>> When we migrate we ask the kernel about its current belief on what the guest
>> time would be. However, I've seen cases where the kvmclock guest structure
>> indicates a time more recent than the kvm returned time.
>>
>> To make sure we never go backwards, calculate what the guest would have seen as time at the point of migration and use that value instead of the kernel returned one when it's more recent.
>> This bases the view of the kvmclock after migration on the
>> same foundation in host as well as guest.
>>
>> Signed-off-by: Alexander Graf <agraf@suse.de>
>> Cc: qemu-stable@nongnu.org
>> Reviewed-by: Marcelo Tosatti <mtosatti@redhat.com>
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>
>
next prev parent reply other threads:[~2014-09-09 21:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-05 13:52 [Qemu-devel] [patch 0/3] kvmclock: Ensure time in migration never goes backward (v3) Marcelo Tosatti
2014-09-05 13:52 ` [Qemu-devel] [patch 1/3] kvmclock: Ensure time in migration never goes backward Marcelo Tosatti
2014-09-09 15:12 ` Marcelo Tosatti
2014-09-09 21:16 ` Alexander Graf [this message]
2014-09-09 23:07 ` Marcelo Tosatti
2014-09-05 13:52 ` [Qemu-devel] [patch 2/3] Introduce cpu_clean_all_dirty Marcelo Tosatti
2014-09-05 13:52 ` [Qemu-devel] [patch 3/3] kvmclock: Ensure proper env->tsc value for kvmclock_current_nsec calculation Marcelo Tosatti
2014-09-05 18:16 ` [Qemu-devel] [patch 0/3] kvmclock: Ensure time in migration never goes backward (v3) Andrey Korolyov
2014-09-05 18:26 ` Marcelo Tosatti
2014-09-05 18:29 ` Paolo Bonzini
2014-09-05 18:35 ` Andrey Korolyov
2014-09-05 19:35 ` Andrey Korolyov
2014-09-05 22:14 ` Paolo Bonzini
2014-09-05 23:05 ` Andrey Korolyov
2014-09-09 17:54 ` Andrey Korolyov
2014-09-16 9:14 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=540F6E3D.7090405@suse.de \
--to=agraf@suse.de \
--cc=andrey@xdel.ru \
--cc=m.gibula@beyond.pl \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).