From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41359) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XRUaZ-0004QV-7Y for qemu-devel@nongnu.org; Tue, 09 Sep 2014 19:12:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XRUaQ-0004Xh-7Q for qemu-devel@nongnu.org; Tue, 09 Sep 2014 19:12:43 -0400 Received: from mail-qa0-x233.google.com ([2607:f8b0:400d:c00::233]:47014) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XRUaQ-0004XV-0p for qemu-devel@nongnu.org; Tue, 09 Sep 2014 19:12:34 -0400 Received: by mail-qa0-f51.google.com with SMTP id j7so16643083qaq.10 for ; Tue, 09 Sep 2014 16:12:33 -0700 (PDT) Sender: Richard Henderson Message-ID: <540F895D.50302@twiddle.net> Date: Tue, 09 Sep 2014 16:12:29 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1410303761-13485-1-git-send-email-jcmvbkbc@gmail.com> In-Reply-To: <1410303761-13485-1-git-send-email-jcmvbkbc@gmail.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] tcg/README: fix movcond cond argument position List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Filippov , qemu-devel@nongnu.org On 09/09/2014 04:02 PM, Max Filippov wrote: > movcond has its cond argument first, not last. Fix that in > documentation. > > Signed-off-by: Max Filippov > --- > tcg/README | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tcg/README b/tcg/README > index a550ff1..69f3456 100644 > --- a/tcg/README > +++ b/tcg/README > @@ -328,7 +328,7 @@ dest = (t1 cond t2) > > Set DEST to 1 if (T1 cond T2) is true, otherwise set to 0. > > -* movcond_i32/i64 dest, c1, c2, v1, v2, cond > +* movcond_i32/i64 cond, dest, c1, c2, v1, v2 No. The README is supposed to be documenting the *opcode* argument ordering, which really does place cond last. I agree the situation with the helpers using a different ordering is confusing. If we were going to change anything to match, it'd have to be the helpers -- the concept of constant opcode arguments coming last is buried quite deep in TCG. r~