From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48181) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fT5Ch-0006D7-2o for qemu-devel@nongnu.org; Wed, 13 Jun 2018 08:48:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fT5Cd-0006we-3C for qemu-devel@nongnu.org; Wed, 13 Jun 2018 08:48:47 -0400 References: <1528866321-23886-1-git-send-email-thuth@redhat.com> <1528866321-23886-2-git-send-email-thuth@redhat.com> From: Paolo Bonzini Message-ID: <540abc07-2b96-bf0b-6f5a-2a4efc5184d9@redhat.com> Date: Wed, 13 Jun 2018 14:48:36 +0200 MIME-Version: 1.0 In-Reply-To: <1528866321-23886-2-git-send-email-thuth@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/4] Replace '-machine accel=xyz' with '-accel xyz' List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth , qemu-devel@nongnu.org Cc: Stefan Hajnoczi , Eduardo Habkost , Ben Warren , zhang.zhanghailiang@huawei.com, Markus Armbruster , qemu-trivial@nongnu.org On 13/06/2018 07:05, Thomas Huth wrote: > diff --git a/tests/vmgenid-test.c b/tests/vmgenid-test.c > index 8d915c6..4324034 100644 > --- a/tests/vmgenid-test.c > +++ b/tests/vmgenid-test.c > @@ -131,7 +131,7 @@ static void read_guid_from_monitor(QemuUUID *guid) > static char disk[] = "tests/vmgenid-test-disk-XXXXXX"; > > #define GUID_CMD(guid) \ > - "-machine accel=kvm:tcg " \ > + "-accel kvm:tcg " \ > "-device vmgenid,id=testvgid,guid=%s " \ "-accel kvm:tcg" works, but it really shouldn't (and I think we can change it without a deprecation period). The right syntax would be "-accel kvm -accel tcg", so that you can specify options that are valid only for KVM, or onlty for TCG. Paolo