* [Qemu-devel] [PATCH] checkpatch: g_test_message does not need a a trailing newline
@ 2018-11-21 18:27 Paolo Bonzini
2018-11-21 18:38 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 4+ messages in thread
From: Paolo Bonzini @ 2018-11-21 18:27 UTC (permalink / raw)
To: qemu-devel; +Cc: thuth
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
scripts/checkpatch.pl | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index eccd656c41..d27bc51f8c 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2802,7 +2802,8 @@ sub process {
info_vreport|
error_report|
warn_report|
- info_report}x;
+ info_report|
+ g_test_message}x;
if ($rawline =~ /\b(?:$qemu_error_funcs)\s*\(.*\".*\\n/) {
ERROR("Error messages should not contain newlines\n" . $herecurr);
--
2.19.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] checkpatch: g_test_message does not need a a trailing newline
2018-11-21 18:27 [Qemu-devel] [PATCH] checkpatch: g_test_message does not need a a trailing newline Paolo Bonzini
@ 2018-11-21 18:38 ` Philippe Mathieu-Daudé
2018-11-22 8:14 ` Thomas Huth
2018-11-22 13:06 ` Paolo Bonzini
0 siblings, 2 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2018-11-21 18:38 UTC (permalink / raw)
To: Paolo Bonzini, qemu-devel; +Cc: thuth
On 21/11/18 19:27, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> scripts/checkpatch.pl | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index eccd656c41..d27bc51f8c 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -2802,7 +2802,8 @@ sub process {
> info_vreport|
> error_report|
> warn_report|
> - info_report}x;
> + info_report|
> + g_test_message}x;
This perl file use <tab> here, shouldn't we keep the same style?
>
> if ($rawline =~ /\b(?:$qemu_error_funcs)\s*\(.*\".*\\n/) {
> ERROR("Error messages should not contain newlines\n" . $herecurr);
>
$ ./scripts/checkpatch.pl -f tests/ipmi-bt-test.c
ERROR: Error messages should not contain newlines
#408: FILE: tests/ipmi-bt-test.c:408:
+ g_test_message("Skipping test for non-x86\n");
total: 1 errors, 0 warnings, 430 lines checked
Nice :)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] checkpatch: g_test_message does not need a a trailing newline
2018-11-21 18:38 ` Philippe Mathieu-Daudé
@ 2018-11-22 8:14 ` Thomas Huth
2018-11-22 13:06 ` Paolo Bonzini
1 sibling, 0 replies; 4+ messages in thread
From: Thomas Huth @ 2018-11-22 8:14 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, Paolo Bonzini, qemu-devel
On 2018-11-21 19:38, Philippe Mathieu-Daudé wrote:
>
>
> On 21/11/18 19:27, Paolo Bonzini wrote:
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>> ---
>> scripts/checkpatch.pl | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
>> index eccd656c41..d27bc51f8c 100755
>> --- a/scripts/checkpatch.pl
>> +++ b/scripts/checkpatch.pl
>> @@ -2802,7 +2802,8 @@ sub process {
>> info_vreport|
>> error_report|
>> warn_report|
>> - info_report}x;
>> + info_report|
>> + g_test_message}x;
>
> This perl file use <tab> here, shouldn't we keep the same style?
+1
Apart from that:
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] checkpatch: g_test_message does not need a a trailing newline
2018-11-21 18:38 ` Philippe Mathieu-Daudé
2018-11-22 8:14 ` Thomas Huth
@ 2018-11-22 13:06 ` Paolo Bonzini
1 sibling, 0 replies; 4+ messages in thread
From: Paolo Bonzini @ 2018-11-22 13:06 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel; +Cc: thuth
On 21/11/18 19:38, Philippe Mathieu-Daudé wrote:
>
>
> On 21/11/18 19:27, Paolo Bonzini wrote:
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>> ---
>> scripts/checkpatch.pl | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
>> index eccd656c41..d27bc51f8c 100755
>> --- a/scripts/checkpatch.pl
>> +++ b/scripts/checkpatch.pl
>> @@ -2802,7 +2802,8 @@ sub process {
>> info_vreport|
>> error_report|
>> warn_report|
>> - info_report}x;
>> + info_report|
>> + g_test_message}x;
>
> This perl file use <tab> here, shouldn't we keep the same style?
>
>> if ($rawline =~ /\b(?:$qemu_error_funcs)\s*\(.*\".*\\n/) {
>> ERROR("Error messages should not contain newlines\n" .
>> $herecurr);
>>
>
> $ ./scripts/checkpatch.pl -f tests/ipmi-bt-test.c
> ERROR: Error messages should not contain newlines
> #408: FILE: tests/ipmi-bt-test.c:408:
> + g_test_message("Skipping test for non-x86\n");
> total: 1 errors, 0 warnings, 430 lines checked
>
> Nice :)
>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Queued then, thanks. :)
Paolo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-11-22 13:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-21 18:27 [Qemu-devel] [PATCH] checkpatch: g_test_message does not need a a trailing newline Paolo Bonzini
2018-11-21 18:38 ` Philippe Mathieu-Daudé
2018-11-22 8:14 ` Thomas Huth
2018-11-22 13:06 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).