From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44757)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XRdvq-0001Iu-CD
	for qemu-devel@nongnu.org; Wed, 10 Sep 2014 05:11:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XRdvj-0007XC-Si
	for qemu-devel@nongnu.org; Wed, 10 Sep 2014 05:11:18 -0400
Received: from mx1.redhat.com ([209.132.183.28]:41045)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XRdvj-0007X6-Lo
	for qemu-devel@nongnu.org; Wed, 10 Sep 2014 05:11:11 -0400
Message-ID: <541015A4.8090907@redhat.com>
Date: Wed, 10 Sep 2014 11:11:00 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <cover.1410240131.git.hutao@cn.fujitsu.com>
	<78be9bf0b4be81bf9e810e42a115e86a199241d2.1410240131.git.hutao@cn.fujitsu.com>
	<540EE299.3080104@redhat.com>
	<20140910020523.GF7193@G08FNSTD100614.fnst.cn.fujitsu.com>
In-Reply-To: <20140910020523.GF7193@G08FNSTD100614.fnst.cn.fujitsu.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v7 RESEND 4/8] memory: add parameter errp
	to memory_region_init_rom_device
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Hu Tao <hutao@cn.fujitsu.com>
Cc: Peter Crosthwaite <peter.crosthwaite@xilinx.com>, "Michael S. Tsirkin" <mst@redhat.com>, qemu-devel@nongnu.org, Yasuaki Isimatu <isimatu.yasuaki@jp.fujitsu.com>, Yasunori Goto <y-goto@jp.fujitsu.com>

Il 10/09/2014 04:05, Hu Tao ha scritto:
>> > 
>> > Better not use error_abort if we can avoid it, and here it's particularly
>> > easy...
> Is error_abort deprecated?

No, not at at all.  It is useful whenever you know that an error cannot
happen.  However, if it makes sense and it is easy, error propagation is
better.  For every patch today that removes an exit(1), tomorrow we
could have a patch that removes an &error_abort.

Paolo