From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49455) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XReFJ-0004rr-EU for qemu-devel@nongnu.org; Wed, 10 Sep 2014 05:31:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XReFB-0005Nc-Vx for qemu-devel@nongnu.org; Wed, 10 Sep 2014 05:31:25 -0400 Received: from cantor2.suse.de ([195.135.220.15]:45732 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XReFB-0005NU-PZ for qemu-devel@nongnu.org; Wed, 10 Sep 2014 05:31:17 -0400 Message-ID: <54101A61.1080503@suse.de> Date: Wed, 10 Sep 2014 11:31:13 +0200 From: Alexander Graf MIME-Version: 1.0 References: <1410249273-6063-1-git-send-email-eric.auger@linaro.org> <1410249273-6063-2-git-send-email-eric.auger@linaro.org> <540EDCF9.7070609@redhat.com> <540F1BF2.4080505@linaro.org> <540F23F6.8080407@redhat.com> In-Reply-To: <540F23F6.8080407@redhat.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 1/6] hw/misc/dyn_sysbus_binding: helpers for sysbus device dynamic binding List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , Eric Auger , eric.auger@st.com, christoffer.dall@linaro.org, qemu-devel@nongnu.org, a.rigo@virtualopensystems.com, kim.phillips@freescale.com, marc.zyngier@arm.com, manish.jaggi@caviumnetworks.com, joel.schopp@amd.com, peter.maydell@linaro.org, afaerber@suse.de Cc: patches@linaro.org, will.deacon@arm.com, stuart.yoder@freescale.com, Bharat.Bhushan@freescale.com, alex.williamson@redhat.com, a.motakis@virtualopensystems.com, kvmarm@lists.cs.columbia.edu On 09.09.14 17:59, Paolo Bonzini wrote: > Il 09/09/2014 17:25, Eric Auger ha scritto: >>>> >>>> Please provide a wrapper like sysbus_register_dynamic that takes the >>>> params/address_space_mem/mpic as parameter. platform_bus_init_notify >>>> and DynSysbusNotifier can remain hidden within the .c file. >> Sorry I do not catch what you mean here. platform_bus_init_notify & >> DynSysbusNotifier are currently used in virt.c to initialize & register >> the machine_init_done_notifier. > > Yeah, please do the registration in sysbus.c, not in virt.c. There is > no reason to make the platform_bus_init_notify+DynSysbusNotifier > interface public. The code in sysbus.c can fill in the fields. Sysbus != Platform bus. Sysbus is an in-QEMU representation of a pseudo-bus that we put all devices onto that we consider unsorted. Platform bus is a machine representation of an actual bus that devices are attached to. These devices usually are sysbus devices. Alex