From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56821) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XReoK-0003d8-B7 for qemu-devel@nongnu.org; Wed, 10 Sep 2014 06:07:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XReoE-0002Jq-6s for qemu-devel@nongnu.org; Wed, 10 Sep 2014 06:07:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:9987) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XReoD-0002Jk-Vr for qemu-devel@nongnu.org; Wed, 10 Sep 2014 06:07:30 -0400 Message-ID: <541022DA.1000503@redhat.com> Date: Wed, 10 Sep 2014 12:07:22 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1410265809-27247-1-git-send-email-pbonzini@redhat.com> <1410265809-27247-10-git-send-email-pbonzini@redhat.com> <20140909135424.GA13212@redhat.com> <540F35E3.7060207@redhat.com> <20140909205122.GB15637@redhat.com> <54100E16.1040306@redhat.com> <20140910105051.GE7902@redhat.com> <541020CA.5000901@redhat.com> <20140910110451.GA11512@redhat.com> In-Reply-To: <20140910110451.GA11512@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 09/10] piix: do not raise irq while loading vmstate List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: amit.shah@redhat.com, quintela@redhat.com, dgilbert@redhat.com, Pavel.Dovgaluk@ispras.ru, qemu-devel@nongnu.org Il 10/09/2014 13:04, Michael S. Tsirkin ha scritto: >> > This patch disables raising an irq while loading the state of PCI bridge. >> > Because the i8259 has not been deserialized yet, raising an interrupt >> > could bring the system out-of-sync with the migration source. For example, >> > the migration source could have masked the interrupt in the i8259. On the >> > destination, the i8259 device model would not know that yet and would >> > trigger an interrupt in the CPU. >> > >> > This patch eliminates raising an irq and just restores the calculated >> > state fields in post_load function. Interrupt state will be deserialized >> > separately through the IRR field of the i8259. > Yes, thanks! > Except imho it's a bit better to s/raising/setting/ in the last paragraph. And pretty much everywhere else, not just in the last paragraph. Thanks! Paolo