From: Alexander Graf <agraf@suse.de>
To: Pierre Mallard <mallard.pierre@gmail.com>,
qemu-devel@nongnu.org, qemu-ppc@nongnu.org
Cc: tommusta@gmail.com
Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH] target-ppc : Make hreg_store_msr returns exception
Date: Wed, 10 Sep 2014 15:19:10 +0200 [thread overview]
Message-ID: <54104FCE.5060905@suse.de> (raw)
In-Reply-To: <1409924717-9133-1-git-send-email-mallard.pierre@gmail.com>
On 05.09.14 15:45, Pierre Mallard wrote:
> hreg_store_msr was both returning 0 or an exception number which could be
> POWERPC_EXCP_NONE. In case POWERPC_EXCP_NONE was returned, helper_store_msr
> was handling uncorrectly this return value and raise an exception. This patch
> correct this behavior by making hreg_store_msr always return an exception
> number, and helper_store_msr test for POWERPC_EXCP_NONE.
>
> Signed-off-by: Pierre Mallard <mallard.pierre@gmail.com>
Are you sure that's a bug, not a feature? I think this idea behind
POWERPC_EXCP_NONE in this code path is to pull the guest out of its TB
so that no stale code could be executed after an MSR.IR/DR change.
Alex
prev parent reply other threads:[~2014-09-10 13:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-05 13:45 [Qemu-devel] [PATCH] target-ppc : Make hreg_store_msr returns exception Pierre Mallard
2014-09-10 13:19 ` Alexander Graf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54104FCE.5060905@suse.de \
--to=agraf@suse.de \
--cc=mallard.pierre@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=tommusta@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).