From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42820) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XRhnq-0008AP-Dv for qemu-devel@nongnu.org; Wed, 10 Sep 2014 09:19:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XRhnj-00081h-Jv for qemu-devel@nongnu.org; Wed, 10 Sep 2014 09:19:18 -0400 Message-ID: <54104FCE.5060905@suse.de> Date: Wed, 10 Sep 2014 15:19:10 +0200 From: Alexander Graf MIME-Version: 1.0 References: <1409924717-9133-1-git-send-email-mallard.pierre@gmail.com> In-Reply-To: <1409924717-9133-1-git-send-email-mallard.pierre@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH] target-ppc : Make hreg_store_msr returns exception List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pierre Mallard , qemu-devel@nongnu.org, qemu-ppc@nongnu.org Cc: tommusta@gmail.com On 05.09.14 15:45, Pierre Mallard wrote: > hreg_store_msr was both returning 0 or an exception number which could be > POWERPC_EXCP_NONE. In case POWERPC_EXCP_NONE was returned, helper_store_msr > was handling uncorrectly this return value and raise an exception. This patch > correct this behavior by making hreg_store_msr always return an exception > number, and helper_store_msr test for POWERPC_EXCP_NONE. > > Signed-off-by: Pierre Mallard Are you sure that's a bug, not a feature? I think this idea behind POWERPC_EXCP_NONE in this code path is to pull the guest out of its TB so that no stale code could be executed after an MSR.IR/DR change. Alex