From: Paolo Bonzini <pbonzini@redhat.com>
To: Fam Zheng <famz@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-devel@nongnu.org, Michael Roth <mdroth@linux.vnet.ibm.com>,
Markus Armbruster <armbru@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] qapi: Fix crash with enum dealloc when kind is invalid
Date: Wed, 10 Sep 2014 17:32:56 +0200 [thread overview]
Message-ID: <54106F28.5080203@redhat.com> (raw)
In-Reply-To: <20140910150200.GA4883@fam-t430.nay.redhat.com>
Il 10/09/2014 17:02, Fam Zheng ha scritto:
> > A bit hackish, but I don't have any better idea.
> >
> > Hmm... what about adding a new member to the visitors for "invalid enum"
> > value? The dealloc visitor could override it to do nothing, while the
> > default could abort or set an error. Would that work?
>
> The invalid state of enum still needs to be saved in the data. It is detected
> by the input visitor, but should be checked by other visitors (output, dealloc)
> later.
Yes, that's fine. The only part where I'm not sure is the special
casing of the _MAX enum.
Paolo
next prev parent reply other threads:[~2014-09-10 15:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-10 12:30 [Qemu-devel] [PATCH] qapi: Fix crash with enum dealloc when kind is invalid Fam Zheng
2014-09-10 13:01 ` Paolo Bonzini
2014-09-10 15:02 ` Fam Zheng
2014-09-10 15:32 ` Paolo Bonzini [this message]
2014-09-11 0:53 ` Fam Zheng
2014-09-11 4:17 ` Eric Blake
2014-09-11 4:38 ` Fam Zheng
2014-09-11 14:26 ` Michael Roth
2014-09-11 14:35 ` Paolo Bonzini
2014-09-11 23:02 ` Michael Roth
2014-09-11 1:01 ` Michael Roth
2014-09-11 1:02 ` [Qemu-devel] [PATCH] tests: add QMP input visitor test for unions with no discriminator Michael Roth
2014-09-11 4:19 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54106F28.5080203@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).