From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54291) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XRkSL-0006lr-TD for qemu-devel@nongnu.org; Wed, 10 Sep 2014 12:09:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XRkSC-0007si-Os for qemu-devel@nongnu.org; Wed, 10 Sep 2014 12:09:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52981) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XRkSC-0007sc-Fx for qemu-devel@nongnu.org; Wed, 10 Sep 2014 12:09:08 -0400 Message-ID: <541077A0.1050003@redhat.com> Date: Wed, 10 Sep 2014 10:09:04 -0600 From: Eric Blake MIME-Version: 1.0 References: <1410336832-22160-1-git-send-email-armbru@redhat.com> <1410336832-22160-9-git-send-email-armbru@redhat.com> In-Reply-To: <1410336832-22160-9-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="EjlsXHna5NrUIOHx91xsEoghisnU7pIPS" Subject: Re: [Qemu-devel] [PATCH 08/23] block: Eliminate BlockDriverState member device_name[] List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: kwolf@redhat.com, benoit.canet@irqsave.net, famz@redhat.com, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --EjlsXHna5NrUIOHx91xsEoghisnU7pIPS Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 09/10/2014 02:13 AM, Markus Armbruster wrote: > device_name[] is can become non-empty only in bdrv_new_named() and s/is // > bdrv_move_feature_fields(). The latter is used only to undo damage > done by bdrv_swap(). The former is called only by blk_new_with_bs(). > Therefore, when a BlockDriverState's device_name[] is non-empty, then > it's owned by a BlockBackend. >=20 > The converse is also true, because blk_attach_bs() is called only by > blk_new_with_bs() so far. >=20 > Furthermore, blk_new_with_bs() keeps the two names equal. >=20 > Therefore, device_name[] is redundant. Eliminate it. >=20 > Signed-off-by: Markus Armbruster > --- --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --EjlsXHna5NrUIOHx91xsEoghisnU7pIPS Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUEHegAAoJEKeha0olJ0NqAlgH/2LIonHn8xV8kmjqGg2Dh+wr EcM/HCZbD+KXaDCZ6XOGT9H+aogytYePnib4PAqzkYRwEt1kRD8VcaFgDW0zzNHU OvJJRrMxsFBQL8CAyf1oJt9Rfl4u5fttJ7RkZEmfY/cmGzkkSnVlAWoCcfwS2NqW SVSQqtIRtn6J1g4IQg4Op8/0IKRhE86ptC0KW5N7N1FOzm/qocvHxiOdbXSMinBq Y+0Cn0ihQVp/xSlyNVdai0PZ9qE1hjZMuNGg1Gd8vMjefgGJWaA9NQr+OTpYIavW PfRL2p86eB90p1d0TSytS95Gvu4gMV2apN7j6TZHsiXcaQdvqQXhqgrAa6+pLF4= =Jyyc -----END PGP SIGNATURE----- --EjlsXHna5NrUIOHx91xsEoghisnU7pIPS--