From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33897) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XRpH8-0001vS-N5 for qemu-devel@nongnu.org; Wed, 10 Sep 2014 17:18:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XRpGz-0008VE-Pb for qemu-devel@nongnu.org; Wed, 10 Sep 2014 17:18:02 -0400 Message-ID: <5410C000.2050408@suse.de> Date: Wed, 10 Sep 2014 23:17:52 +0200 From: Alexander Graf MIME-Version: 1.0 References: <1409307142-2600-1-git-send-email-aik@ozlabs.ru> <1409307142-2600-17-git-send-email-aik@ozlabs.ru> <54104C39.4010106@suse.de> <541067AB.6030205@ozlabs.ru> In-Reply-To: <541067AB.6030205@ozlabs.ru> Content-Type: text/plain; charset=koi8-r Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH v3 16/18] spapr_pci_vfio: Enable DDW List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy , qemu-devel@nongnu.org Cc: Alex Williamson , qemu-ppc@nongnu.org, David Gibson On 10.09.14 17:00, Alexey Kardashevskiy wrote: > On 09/10/2014 11:03 PM, Alexander Graf wrote: >> >> >> On 29.08.14 12:12, Alexey Kardashevskiy wrote: >>> This implements DDW for VFIO. Host kernel support is required for this. >>> >>> After this patch DDW will be enabled on all machines but pseries-2.1. >> >> I fail to see the code that restricts DDW to pseries-2.1. Can you please >> point me to it? > > Patch "[RFC PATCH v3 13/18] spapr_pci: Enable DDW" which enables DDW on > spapr-pci disables it for the current machine by default. > > Since spapr-pci-vfio inherits from spapr-pci, this property is off for > pseries-2.1 as well (I checked). Ah, I see. The logic is still reversed. Old machine types get compat options, new machine types don't. So the default should be "ddw enabled" and pseries-2.1 gets a compat field saying "disable ddw". Alex