From: Eric Blake <eblake@redhat.com>
To: Michael Roth <mdroth@linux.vnet.ibm.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] tests: add QMP input visitor test for unions with no discriminator
Date: Wed, 10 Sep 2014 22:19:45 -0600 [thread overview]
Message-ID: <541122E1.6080005@redhat.com> (raw)
In-Reply-To: <1410397360-14174-1-git-send-email-mdroth@linux.vnet.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 1006 bytes --]
On 09/10/2014 07:02 PM, Michael Roth wrote:
> This more an exercise of the dealloc visitor, where it may erroneously
This is more of an exercise...
> use an uninitialized discriminator field as indication that union
> fields corresponding to that disciminator field/type are present,
discriminator
> which can lead to attempts to free random chunks of heap memory.
>
> Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
> ---
> tests/qapi-schema/qapi-schema-test.json | 10 ++++++++++
> tests/qapi-schema/qapi-schema-test.out | 3 +++
> tests/test-qmp-input-strict.c | 17 +++++++++++++++++
> 3 files changed, 30 insertions(+)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
[conflicts with my stalled attempt to nuke inline sub-structs in json
files, where I've promised to send a v4 - guess I'll be rebasing as part
of reviving that series...]
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]
prev parent reply other threads:[~2014-09-11 4:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-10 12:30 [Qemu-devel] [PATCH] qapi: Fix crash with enum dealloc when kind is invalid Fam Zheng
2014-09-10 13:01 ` Paolo Bonzini
2014-09-10 15:02 ` Fam Zheng
2014-09-10 15:32 ` Paolo Bonzini
2014-09-11 0:53 ` Fam Zheng
2014-09-11 4:17 ` Eric Blake
2014-09-11 4:38 ` Fam Zheng
2014-09-11 14:26 ` Michael Roth
2014-09-11 14:35 ` Paolo Bonzini
2014-09-11 23:02 ` Michael Roth
2014-09-11 1:01 ` Michael Roth
2014-09-11 1:02 ` [Qemu-devel] [PATCH] tests: add QMP input visitor test for unions with no discriminator Michael Roth
2014-09-11 4:19 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=541122E1.6080005@redhat.com \
--to=eblake@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).