From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39518) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XRxqt-0005GO-Qj for qemu-devel@nongnu.org; Thu, 11 Sep 2014 02:27:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XRxqk-0002zv-PS for qemu-devel@nongnu.org; Thu, 11 Sep 2014 02:27:31 -0400 Received: from e31.co.us.ibm.com ([32.97.110.149]:37040) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XRxqk-0002zr-HR for qemu-devel@nongnu.org; Thu, 11 Sep 2014 02:27:22 -0400 Received: from /spool/local by e31.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 11 Sep 2014 00:27:21 -0600 Received: from b03cxnp08028.gho.boulder.ibm.com (b03cxnp08028.gho.boulder.ibm.com [9.17.130.20]) by d03dlp03.boulder.ibm.com (Postfix) with ESMTP id D59B019D803D for ; Thu, 11 Sep 2014 00:27:05 -0600 (MDT) Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170]) by b03cxnp08028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id s8B6RI9s48627724 for ; Thu, 11 Sep 2014 08:27:18 +0200 Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1]) by d03av04.boulder.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s8B6RIHt002014 for ; Thu, 11 Sep 2014 00:27:18 -0600 Message-ID: <541140C3.5020809@linux.vnet.ibm.com> Date: Thu, 11 Sep 2014 14:27:15 +0800 From: "Michael R. Hines" MIME-Version: 1.0 References: <54101328.4070802@huawei.com> <54110187.7060107@linux.vnet.ibm.com> <54113F97.7070602@redhat.com> In-Reply-To: <54113F97.7070602@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] ballooning not working on hotplugged pc-dimm List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , zhanghailiang , Alexandre DERUMIER Cc: hinesmr@cn.ibm.com, qemu-devel On 09/11/2014 02:22 PM, Paolo Bonzini wrote: > Il 11/09/2014 03:57, Michael R. Hines ha scritto: >> Why does hotplugging use a different name? >> >> This also affects RDMA live migration - we are explicitly looking up >> "pc.ram" ram blocks and pinning them for memory registration with Linux. > Are we? I cannot see any code that special cases pc.ram (it only > appears in a couple of comments). It'd also be surprising to see that > escaping review. :) > > Paolo > You're absolutely right =) I was thinking about old code. We loop through all the ram blocks. Good sanity check, though =) - Michael