From: zhanghailiang <zhang.zhanghailiang@huawei.com>
To: "Michael R. Hines" <mrhines@linux.vnet.ibm.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
hinesmr@cn.ibm.com, qemu-devel <qemu-devel@nongnu.org>,
Alexandre DERUMIER <aderumier@odiso.com>
Subject: Re: [Qemu-devel] ballooning not working on hotplugged pc-dimm
Date: Thu, 11 Sep 2014 14:33:33 +0800 [thread overview]
Message-ID: <5411423D.5070401@huawei.com> (raw)
In-Reply-To: <541140C3.5020809@linux.vnet.ibm.com>
On 2014/9/11 14:27, Michael R. Hines wrote:
> On 09/11/2014 02:22 PM, Paolo Bonzini wrote:
>> Il 11/09/2014 03:57, Michael R. Hines ha scritto:
>>> Why does hotplugging use a different name?
>>>
>>> This also affects RDMA live migration - we are explicitly looking up
>>> "pc.ram" ram blocks and pinning them for memory registration with Linux.
>> Are we? I cannot see any code that special cases pc.ram (it only
>> appears in a couple of comments). It'd also be surprising to see that
>> escaping review. :)
>>
>> Paolo
>>
>
>
> You're absolutely right =) I was thinking about old code. We loop through all the ram blocks.
>
> Good sanity check, though =)
>
> - Michael
>
>
>
Hmm, in this case, it is better to remove this confused comments;-)
prev parent reply other threads:[~2014-09-11 6:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <0a98da72-f316-4e2b-8327-201f85a6e879@mailpro>
2014-09-09 3:05 ` [Qemu-devel] ballooning not working on hotplugged pc-dimm Alexandre DERUMIER
2014-09-10 9:00 ` zhanghailiang
2014-09-11 1:57 ` Michael R. Hines
2014-09-11 6:22 ` Paolo Bonzini
2014-09-11 6:27 ` Michael R. Hines
2014-09-11 6:33 ` zhanghailiang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5411423D.5070401@huawei.com \
--to=zhang.zhanghailiang@huawei.com \
--cc=aderumier@odiso.com \
--cc=hinesmr@cn.ibm.com \
--cc=mrhines@linux.vnet.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).