From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Fabiano Rosas <farosas@suse.de>, qemu-devel@nongnu.org
Cc: Juan Quintela <quintela@redhat.com>, Peter Xu <peterx@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Leonardo Bras <leobras@redhat.com>
Subject: Re: [PATCH 3/3] migration/multifd: Clarify Error usage in multifd_channel_connect
Date: Thu, 12 Oct 2023 15:53:23 +0200 [thread overview]
Message-ID: <541180d9-fb7c-17b3-ab96-c5afd2a61a33@linaro.org> (raw)
In-Reply-To: <20231012134343.23757-4-farosas@suse.de>
On 12/10/23 15:43, Fabiano Rosas wrote:
> The function is currently called from two sites, one always gives it a
> NULL Error and the other always gives it a non-NULL Error.
>
> In the non-NULL case, all it does it trace the error and return. One
> of the callers already have tracing, add a tracepoint to the other and
> stop passing the error into the function.
>
> Cc: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Fabiano Rosas <farosas@suse.de>
> ---
> migration/multifd.c | 60 ++++++++++++++++++++----------------------
> migration/trace-events | 3 ++-
> 2 files changed, 30 insertions(+), 33 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2023-10-12 13:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-12 13:43 [PATCH 0/3] migration/multifd: General cleanups Fabiano Rosas
2023-10-12 13:43 ` [PATCH 1/3] migration/multifd: Remove direct "socket" references Fabiano Rosas
2023-10-12 13:53 ` Philippe Mathieu-Daudé
2023-10-16 8:45 ` Juan Quintela
2023-10-12 13:43 ` [PATCH 2/3] migration/multifd: Unify multifd_send_thread error paths Fabiano Rosas
2023-10-16 8:48 ` Juan Quintela
2023-10-12 13:43 ` [PATCH 3/3] migration/multifd: Clarify Error usage in multifd_channel_connect Fabiano Rosas
2023-10-12 13:53 ` Philippe Mathieu-Daudé [this message]
2023-10-16 8:50 ` Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=541180d9-fb7c-17b3-ab96-c5afd2a61a33@linaro.org \
--to=philmd@linaro.org \
--cc=armbru@redhat.com \
--cc=farosas@suse.de \
--cc=leobras@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).