From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38377)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <borntraeger@de.ibm.com>) id 1XS3hW-000562-Mw
	for qemu-devel@nongnu.org; Thu, 11 Sep 2014 08:42:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <borntraeger@de.ibm.com>) id 1XS3hK-0001iR-VS
	for qemu-devel@nongnu.org; Thu, 11 Sep 2014 08:42:14 -0400
Received: from e06smtp12.uk.ibm.com ([195.75.94.108]:44402)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <borntraeger@de.ibm.com>) id 1XS3hK-0001iE-Lr
	for qemu-devel@nongnu.org; Thu, 11 Sep 2014 08:42:02 -0400
Received: from /spool/local
	by e06smtp12.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <borntraeger@de.ibm.com>;
	Thu, 11 Sep 2014 13:42:01 +0100
Message-ID: <54119894.6020101@de.ibm.com>
Date: Thu, 11 Sep 2014 14:41:56 +0200
From: Christian Borntraeger <borntraeger@de.ibm.com>
MIME-Version: 1.0
References: <1409848699-28374-1-git-send-email-stefanha@redhat.com>
	<1409848699-28374-4-git-send-email-stefanha@redhat.com>
	<5411935E.7020402@de.ibm.com> <20140911123825.GB25518@redhat.com>
In-Reply-To: <20140911123825.GB25518@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PULL 3/6] virtio: don't call device on !vm_running
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, Jason Wang <jasowang@redhat.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>, qemu-stable@nongnu.org

On 11/09/14 14:38, Michael S. Tsirkin wrote:
>> > 
>> > This broke managedsave on s390x:
>> > qemu-system-s390x: hw/net/virtio-net.c:1348: virtio_net_save: Assertion `!n->vhost_started' failed.
>> > reverting that commit makes it working again.
>> > Any ideas?
>> > 
>> > Christian
> 
> Does it help if you apply
> [PULL v2 09/16] vhost_net: cleanup start/stop condition
> on top?
> 

This patch is part of my tree (I am testing qemu/master + some s390 specific patches)

Christian