From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48040) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XSAEV-0006gz-Uq for qemu-devel@nongnu.org; Thu, 11 Sep 2014 15:40:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XSAER-0002ky-FG for qemu-devel@nongnu.org; Thu, 11 Sep 2014 15:40:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:21223) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XSAER-0002ks-79 for qemu-devel@nongnu.org; Thu, 11 Sep 2014 15:40:39 -0400 Message-ID: <5411FAB3.9080409@redhat.com> Date: Thu, 11 Sep 2014 13:40:35 -0600 From: Eric Blake MIME-Version: 1.0 References: <1410336832-22160-1-git-send-email-armbru@redhat.com> <1410336832-22160-11-git-send-email-armbru@redhat.com> <20140911170604.GA9475@irqsave.net> <874mwe7yz7.fsf@blackfin.pond.sub.org> <20140911193359.GA7305@irqsave.net> In-Reply-To: <20140911193359.GA7305@irqsave.net> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="RVSA5HFTNlNDxVM7Swdstm9JGKx8Acq81" Subject: Re: [Qemu-devel] [PATCH 10/23] block: Eliminate DriveInfo member bdrv, use blk_by_legacy_dinfo() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QmVub8OudCBDYW5ldA==?= , Markus Armbruster Cc: kwolf@redhat.com, famz@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --RVSA5HFTNlNDxVM7Swdstm9JGKx8Acq81 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 09/11/2014 01:34 PM, Beno=C3=AEt Canet wrote: > The Thursday 11 Sep 2014 =C3=A0 21:12:44 (+0200), Markus Armbruster wro= te : >> Beno=C3=AEt Canet writes: >> >>>> + blk_bs(blk_by_legacy_dinfo(dinfo= ))); >>> >>> This seems to be a fairly common pattern: "blk_bs(blk_by_legacy_dinfo= ())". >>> How about a helper function ? >> >> Yes, except the pattern is going to evaporate in patch 14 :) >=20 > haha Still, worth mentioning this fact in the commit message, rather than making reviewers guess at it (that is, add a sentence something like: This commit mechanically introduces long lines via repetitive pattern replacement that will be shortened in a later patch --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --RVSA5HFTNlNDxVM7Swdstm9JGKx8Acq81 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUEfq0AAoJEKeha0olJ0NqJtUIAJWo6x+MPsLn4vvI90F9zUrx vIEsAXPL2MpsrqXXku95EO+Duzz8pYEaORvkWvX6xjnXAOaTcnGQ/IrGsJpdpEkm bI/I0gVQS/A9sw6UwTXbsnnqUknqQEmLk1hrhgvSFMbx3iVuQkwPAVfIz4TA3urY 7xpfgy4BpaHVC92gEWrs8JDRj9iU9Vhqpp+L21a5umd9V8gUPxQeudIDWp/pDn2G /Wh/Iln0vnrzQ9N8xTnDuMt8af7nSgCDanIstiErKZTm8GjeXyWldTUv2Y4rw/k2 4SsWAj271Yx6pU656nBqWqSiX2W0BN4k9MbrpCYDIZWHs9kgkHs4sCW1+HjbTSc= =SSZ0 -----END PGP SIGNATURE----- --RVSA5HFTNlNDxVM7Swdstm9JGKx8Acq81--