From: Paolo Bonzini <pbonzini@redhat.com>
To: Claudio Fontana <cfontana@suse.de>, qemu-devel@nongnu.org
Subject: Re: [PATCH v5] replay: do not build if TCG is not available
Date: Wed, 21 Oct 2020 17:26:31 +0200 [thread overview]
Message-ID: <5411d46d-68f1-94e6-4739-8b726f40a617@redhat.com> (raw)
In-Reply-To: <b745024a-73df-cca4-d660-111454e68552@suse.de>
On 21/10/20 16:46, Claudio Fontana wrote:
> in your respin you have not included my change which surrounds
>
> if (replay_can_snapshot())
>
> around a
>
> if (tcg_enabled()) {
> }
>
> therefore leading to failure of all attempts to snapshot under --disable-tcg.
>
> Alternatively, you can change the stub to return "true" (replay_can_snapshot()),
> although its meaning can be quite surprising for the reader under --disable-tcg.
Yeah, and it actually makes sense since
return replay_mode == REPLAY_MODE_NONE
|| !replay_has_events();
would always be true.
Paolo
prev parent reply other threads:[~2020-10-21 15:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-21 12:37 [PATCH v5] replay: do not build if TCG is not available Paolo Bonzini
2020-10-21 14:46 ` Claudio Fontana
2020-10-21 15:26 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5411d46d-68f1-94e6-4739-8b726f40a617@redhat.com \
--to=pbonzini@redhat.com \
--cc=cfontana@suse.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).