From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36774) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XSHHr-0006nW-RM for qemu-devel@nongnu.org; Thu, 11 Sep 2014 23:12:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XSHHm-0004vX-PU for qemu-devel@nongnu.org; Thu, 11 Sep 2014 23:12:39 -0400 Message-ID: <5412648F.90901@redhat.com> Date: Fri, 12 Sep 2014 11:12:15 +0800 From: Jason Wang MIME-Version: 1.0 References: <1410452301-28533-1-git-send-email-mst@redhat.com> In-Reply-To: <1410452301-28533-1-git-send-email-mst@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/2] virtio-net: drop assert on vm stop List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" , qemu-devel@nongnu.org Cc: qemu-stable@nongnu.org, Anthony Liguori On 09/12/2014 12:18 AM, Michael S. Tsirkin wrote: > On vm stop, vm_running state set to stopped > before device is notified, so callbacks can get envoked with > vm_running = false; and this is not an error. This is consistent with virtio-blk which also has such kinds of callbacks. This fixes the issue of qemu crashing when stop during transmission. Acked-by: Jason Wang > Cc: qemu-stable@nongnu.org > Cc: Jason Wang > Signed-off-by: Michael S. Tsirkin > --- > hw/net/virtio-net.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c > index 826a2a5..2040eac 100644 > --- a/hw/net/virtio-net.c > +++ b/hw/net/virtio-net.c > @@ -1125,8 +1125,6 @@ static int32_t virtio_net_flush_tx(VirtIONetQueue *q) > return num_packets; > } > > - assert(vdev->vm_running); > - > if (q->async_tx.elem.out_num) { > virtio_queue_set_notification(q->tx_vq, 0); > return num_packets;