From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55179) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XSMKN-0008KA-8S for qemu-devel@nongnu.org; Fri, 12 Sep 2014 04:35:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XSMKH-000102-PB for qemu-devel@nongnu.org; Fri, 12 Sep 2014 04:35:35 -0400 Received: from mail-wi0-x22d.google.com ([2a00:1450:400c:c05::22d]:62663) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XSMKH-0000zh-IR for qemu-devel@nongnu.org; Fri, 12 Sep 2014 04:35:29 -0400 Received: by mail-wi0-f173.google.com with SMTP id em10so160628wid.12 for ; Fri, 12 Sep 2014 01:35:28 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <5412B04A.1060407@redhat.com> Date: Fri, 12 Sep 2014 10:35:22 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1410507050-8900-1-git-send-email-arei.gonglei@huawei.com> In-Reply-To: <1410507050-8900-1-git-send-email-arei.gonglei@huawei.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v2 0/2] usb: Don't use qerror_report List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: arei.gonglei@huawei.com, qemu-devel@nongnu.org Cc: weidong.huang@huawei.com, kraxel@redhat.com, armbru@redhat.com Il 12/09/2014 09:30, arei.gonglei@huawei.com ha scritto: > From: Gonglei > > qerror_report() is a transitional interface to help with converting > existing HMP commands to QMP. It should not be used elsewhere. > > v2 -> v1: > - update including head files, remove qerror.h and monitor.h, > add error-report.h (Markus) > - add 'Reviewed-by' tag. > > Gonglei (2): > redirect.c: Don't use qerror_report() > dev-network: Don't use qerror_report_err() > > hw/usb/dev-network.c | 4 ++-- > hw/usb/redirect.c | 8 ++++---- > 2 files changed, 6 insertions(+), 6 deletions(-) > This is not an improvement I think; patch 1 especially for patch 2 where you are discarding the Error *. Any chance you could convert USB from init to realize, instead? Then you can remove the error printing altogether, and just the obsolete functions. Paolo