From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60203) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XSMhp-0003DB-5F for qemu-devel@nongnu.org; Fri, 12 Sep 2014 04:59:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XSMhg-00089O-3E for qemu-devel@nongnu.org; Fri, 12 Sep 2014 04:59:49 -0400 Received: from mail-wi0-x233.google.com ([2a00:1450:400c:c05::233]:39939) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XSMhf-00089E-SG for qemu-devel@nongnu.org; Fri, 12 Sep 2014 04:59:40 -0400 Received: by mail-wi0-f179.google.com with SMTP id hi2so198010wib.12 for ; Fri, 12 Sep 2014 01:59:38 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <5412B5F0.6090305@redhat.com> Date: Fri, 12 Sep 2014 10:59:28 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1410507050-8900-1-git-send-email-arei.gonglei@huawei.com> <5412B04A.1060407@redhat.com> <33183CC9F5247A488A2544077AF1902086DC9F84@SZXEMA503-MBS.china.huawei.com> In-Reply-To: <33183CC9F5247A488A2544077AF1902086DC9F84@SZXEMA503-MBS.china.huawei.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 0/2] usb: Don't use qerror_report List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Gonglei (Arei)" , "qemu-devel@nongnu.org" Cc: "Huangweidong (C)" , "kraxel@redhat.com" , "armbru@redhat.com" Il 12/09/2014 10:50, Gonglei (Arei) ha scritto: >> > Any chance you could convert USB from init to realize, instead? Then >> > you can remove the error printing altogether, and just the obsolete >> > functions. >> > > As far as I can tell, almost all devices belong to USB sub-system are > using init method. It may be a big surgery if change all those devices > from init to realize. :) Yes, that would have to be done in the whole USB subsystem. I understand that you don't feel like doing that. :) Paolo