From: Richard Henderson <rth@twiddle.net>
To: Claudio Fontana <claudio.fontana@huawei.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/2] tcg-aarch64: Use 32-bit loads for qemu_ld_i32
Date: Fri, 12 Sep 2014 08:49:23 -0700 [thread overview]
Message-ID: <54131603.1070202@twiddle.net> (raw)
In-Reply-To: <5412FFC6.7040903@huawei.com>
On 09/12/2014 07:14 AM, Claudio Fontana wrote:
>> > +++ b/tcg/tcg.h
>> > @@ -194,7 +194,6 @@ typedef struct TCGPool {
>> > typedef enum TCGType {
>> > TCG_TYPE_I32,
>> > TCG_TYPE_I64,
>> > - TCG_TYPE_COUNT, /* number of different types */
>> >
>> > /* An alias for the size of the host register. */
>> > #if TCG_TARGET_REG_BITS == 32
>> > @@ -218,6 +217,8 @@ typedef enum TCGType {
>> > #endif
>> > } TCGType;
>> >
>> > +#define TCG_TYPE_COUNT 2
>> > +
> why this move from the enum to this standalone define?
>
Becuase having the 2 in the enum makes the compiler think we need 2 bits to
store the enum instead of one. I should probably have pulled that out.
r~
prev parent reply other threads:[~2014-09-12 15:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-03 16:46 [Qemu-devel] [PATCH 0/2] tcg/aarch64 improvement Richard Henderson
2014-09-03 16:46 ` [Qemu-devel] [PATCH 1/2] tcg: Compress TCGLabelQemuLdst Richard Henderson
2014-09-08 15:16 ` Claudio Fontana
2014-09-03 16:46 ` [Qemu-devel] [PATCH 2/2] tcg-aarch64: Use 32-bit loads for qemu_ld_i32 Richard Henderson
2014-09-12 14:14 ` Claudio Fontana
2014-09-12 15:49 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54131603.1070202@twiddle.net \
--to=rth@twiddle.net \
--cc=claudio.fontana@huawei.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).