From: John Snow <jsnow@redhat.com>
To: Fam Zheng <famz@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>,
QEMU Trivial <qemu-trivial@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] curl: Cast fd to int for DPRINTF
Date: Mon, 1 Aug 2016 22:59:10 -0400 [thread overview]
Message-ID: <54132026-6fad-5201-a793-4c312dce9c65@redhat.com> (raw)
In-Reply-To: <20160802010906.GA680@ad.usersys.redhat.com>
On 08/01/2016 09:09 PM, Fam Zheng wrote:
> On Mon, 08/01 12:41, John Snow wrote:
>>> - DPRINTF("CURL (AIO): Sock action %d on fd %d\n", action, fd);
>>> + DPRINTF("CURL (AIO): Sock action %d on fd %d\n", action, (int)fd);
>>> switch (action) {
>>> case CURL_POLL_IN:
>>> aio_set_fd_handler(s->aio_context, fd, false,
>>>
>>
>> Is curl_socket_t always of type long long unsigned int? why not use %llu ?
>
> Since it is a typedef, variation between platforms is imaginable. On Linux it
> is 4 bytes, the error is only seen on Windows.
>
> Fam
>
Ah, there we go. The B-O-D was justified. :)
next prev parent reply other threads:[~2016-08-02 2:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-01 5:04 [Qemu-devel] [PATCH] curl: Cast fd to int for DPRINTF Fam Zheng
2016-08-01 16:41 ` John Snow
2016-08-02 1:09 ` Fam Zheng
2016-08-02 2:59 ` John Snow [this message]
2016-08-10 2:41 ` Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54132026-6fad-5201-a793-4c312dce9c65@redhat.com \
--to=jsnow@redhat.com \
--cc=famz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).