From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54197) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XT5U3-0000Ag-O5 for qemu-devel@nongnu.org; Sun, 14 Sep 2014 04:48:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XT5Tw-0007Dn-Pb for qemu-devel@nongnu.org; Sun, 14 Sep 2014 04:48:35 -0400 Received: from mail-wg0-x22d.google.com ([2a00:1450:400c:c00::22d]:33602) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XT5Tw-0007Da-Iw for qemu-devel@nongnu.org; Sun, 14 Sep 2014 04:48:28 -0400 Received: by mail-wg0-f45.google.com with SMTP id z12so2608703wgg.16 for ; Sun, 14 Sep 2014 01:48:27 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <54155656.4000200@redhat.com> Date: Sun, 14 Sep 2014 10:48:22 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1410675949-1437-1-git-send-email-ghammer@redhat.com> In-Reply-To: <1410675949-1437-1-git-send-email-ghammer@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH RESEND 0/2 V2] Virtual Machine Generation ID List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gal Hammer , qemu-devel@nongnu.org Cc: armbru@redhat.com Il 14/09/2014 08:25, Gal Hammer ha scritto: > Hi, > > A two parts patch to add a QEmu support for Microsoft's Virtual Machine > Generation ID device. > > The first one add a new ACPI directive which allow to use a 16-bytes > buffer in an ACPI table. This buffer is for storing the VM's UUID. > > The second is the ACPI tables changes and the actual device. > > Your comment are welcomed. > > Thanks, > > Gal. > > V2: - Remove "-uuid" command line parameter. > - Move device's description from SSDT to DDST table. > - Add new "vmgenid" sysbus device. > > Gal Hammer (2): > i386: Add an ACPI_EXTRACT_NAME_BUFFER16 directive. > i386: Add a Virtual Machine Generation ID device. > > default-configs/i386-softmmu.mak | 1 + > default-configs/x86_64-softmmu.mak | 1 + > hw/i386/acpi-build.c | 23 ++++++++++- > hw/i386/acpi-dsdt.dsl | 37 +++++++++++++++++ > hw/misc/Makefile.objs | 1 + > hw/misc/vmgenid.c | 85 ++++++++++++++++++++++++++++++++++++++ > include/hw/i386/pc.h | 3 ++ > scripts/acpi_extract.py | 23 +++++++---- > 8 files changed, 163 insertions(+), 11 deletions(-) > create mode 100644 hw/misc/vmgenid.c > The idea is okay, but the device has to be added to the Q35 DSDT as well. If you just #included a file in the same style as acpi-dsdt-hpet.dsl, you would have a namespace clash between the PIIX and Q35 DSDTs. acpi-dsdt-hpet.dsl can do it because it has no ACPI_EXTRACT directives. I think because of this, it is a bit simpler to add the device optionally to the SSDT, similar to how the TPM is handled. Paolo