From: Paolo Bonzini <pbonzini@redhat.com>
To: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 1/2] scsi: Optimize scsi_req_alloc
Date: Mon, 15 Sep 2014 12:15:48 +0200 [thread overview]
Message-ID: <5416BC54.4070507@redhat.com> (raw)
In-Reply-To: <1410758605-29375-2-git-send-email-famz@redhat.com>
Il 15/09/2014 07:23, Fam Zheng ha scritto:
> + uint8_t sense[SCSI_SENSE_BUF_SIZE];
> + uint32_t sense_len;
> + bool enqueued;
> + bool io_canceled;
> + bool retry;
> + bool dma_started;
> SCSICommand cmd;
> BlockDriverAIOCB *aiocb;
> QEMUSGList *sg;
> - bool dma_started;
> - uint8_t sense[SCSI_SENSE_BUF_SIZE];
> - uint32_t sense_len;
> - bool enqueued;
> - bool io_canceled;
> - bool retry;
> - void *hba_private;
> QTAILQ_ENTRY(SCSIRequest) next;
Similar to v1, cmd is filled in by scsi_req_new and can be moved to the
uninitialized area.
Paolo
next prev parent reply other threads:[~2014-09-15 10:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-15 5:23 [Qemu-devel] [PATCH v2 0/2] virtio-scsi: Optimizing request allocation Fam Zheng
2014-09-15 5:23 ` [Qemu-devel] [PATCH v2 1/2] scsi: Optimize scsi_req_alloc Fam Zheng
2014-09-15 10:15 ` Paolo Bonzini [this message]
2014-09-15 5:23 ` [Qemu-devel] [PATCH v2 2/2] virtio-scsi: Optimize virtio_scsi_init_req Fam Zheng
2014-09-15 10:17 ` Paolo Bonzini
2014-09-16 7:16 ` Fam Zheng
2014-09-16 8:15 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5416BC54.4070507@redhat.com \
--to=pbonzini@redhat.com \
--cc=famz@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).