From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44136)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1XTTKM-0004Bo-HT
	for qemu-devel@nongnu.org; Mon, 15 Sep 2014 06:16:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1XTTKA-0006RY-7m
	for qemu-devel@nongnu.org; Mon, 15 Sep 2014 06:16:10 -0400
Received: from mail-lb0-x235.google.com ([2a00:1450:4010:c04::235]:40268)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1XTTK9-0006RO-TE
	for qemu-devel@nongnu.org; Mon, 15 Sep 2014 06:15:58 -0400
Received: by mail-lb0-f181.google.com with SMTP id z11so4070579lbi.26
	for <qemu-devel@nongnu.org>; Mon, 15 Sep 2014 03:15:56 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <5416BC54.4070507@redhat.com>
Date: Mon, 15 Sep 2014 12:15:48 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1410758605-29375-1-git-send-email-famz@redhat.com>
	<1410758605-29375-2-git-send-email-famz@redhat.com>
In-Reply-To: <1410758605-29375-2-git-send-email-famz@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 1/2] scsi: Optimize scsi_req_alloc
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org

Il 15/09/2014 07:23, Fam Zheng ha scritto:
> +    uint8_t           sense[SCSI_SENSE_BUF_SIZE];
> +    uint32_t          sense_len;
> +    bool              enqueued;
> +    bool              io_canceled;
> +    bool              retry;
> +    bool              dma_started;
>      SCSICommand       cmd;
>      BlockDriverAIOCB  *aiocb;
>      QEMUSGList        *sg;
> -    bool              dma_started;
> -    uint8_t sense[SCSI_SENSE_BUF_SIZE];
> -    uint32_t sense_len;
> -    bool enqueued;
> -    bool io_canceled;
> -    bool retry;
> -    void *hba_private;
>      QTAILQ_ENTRY(SCSIRequest) next;

Similar to v1, cmd is filled in by scsi_req_new and can be moved to the
uninitialized area.

Paolo